Comment by ~adrinux on ~amolith/willow
Prettier is a logical choice, no argument there. But it has options to control the formatting and that's where personal preferences and argument can creep in :)
It's also useful to have editors do the formatting whilst coding so configuring Prettier via an
.editorconfig
would be nice.
Ticket created by ~adrinux on ~amolith/willow
I've started sketching out some changes to the card layout with Penpot (my first use of the tool) which I've found a bit limited, so view all spacing, alignment etc in this screenshot as...sketchy.
View screenshot or Download directly
A couple of possibilities pictured, labeled option 1 and 2.
Common suggested changes:
- Move the delete link, change its colour
- Remove the question mark from delete, it implies a confirmation step.
- Align the current and Latest version numbers for easy comparison of minor versions
- Associate the 'release notes' more closely with the new version
Option 2 goes a step further and moves the link on the card title to it's own button. The card title might be better linked to a project edit page as per #54
I've just realised I forgot to include the 'Modify?' link... And had a third idea where the visit/modify and release notes links are all to the right of the card, delete on the left...
Feedback and suggestions welcome.
Comment by ~adrinux on ~amolith/willow
I was pondering the usability of the current forge selection form, particularly concerning Codeberg, where a user has to know that Codeberg is built on Forgejo to make the right choice. Auto-selection of forge based on URL would address that nicely.
Comment by ~adrinux on ~amolith/willow
Personally I like the way goHugo implements templates, where they end up as HTML files with snippets of go/hugo template code inside. As opposed to the way templ docs present code: go/templ files with snippets of HTML.
It's mostly because editors tend to syntax highlight and autocomplete HTML well in the former case and badly or not at all in the latter. Writing, modifying and correcting HTML gets a lot harder IMO in with the latter approach. I suppose the choice comes down to whether you're mostly writing HTML with a few bits of template logic or a lot of template logic with a few bits of HTML.
I'm also wondering whether a full template system isn't overkill for Willow at this point, what it mostly needs -- from a front end view -- is a way to include the common page elements header, footer and the head meta elements from a single source.
Ticket created by ~adrinux on ~amolith/willow
I find the current two column layout somewhat awkward to use. Rather than fix the current centering -- issue #43 -- it may be better change the functionality.
I'd like to suggest this is a perfect use for the new browser native -- so no Javascript required -- Popover API.
The decision then is whether the release notes should appear as a non-modal tool tip style box (preferably with some visual connection to the relevant project card) or a full modal dialog style that uses the whole browser window. Personally I favour the latter because many projects have very big release notes.
The one caveat with the Popover API is it only reached 'Baseline' browser support in April 2024 when Firefox finally added support, so anyone stuck on an old browser release may have issues.
I'm happy to take a crack at implementing this if you're willing to let go of the two column layout...
Ticket created by ~adrinux on ~amolith/willow
A feature request: I think it would be nice if there was a sticky page footer with some information and links:
- Current running version of Willow
- Link to Willow home page
- Link to the issue queue
Comment by ~adrinux on ~amolith/willow
The overall page layout probably needs moved to CSS grid with flexbox used for the column layout.
I was going to fix this but I'm finding the two column layout awkward and annoying. So see issue #48 -- if that suggestion is acceptable this issue will become moot.