~amiryal

Israel


#286 Optimize update hook for multiple refs by using pre-receive instead 2 months ago

Ticket created by ~amiryal on ~sircmpwn/git.sr.ht

As I read in the blog[1] and confirmed in the source code[2], the update hook runs multiple times per push, if there is more than one ref to update. This can be optimized by using the pre-receive hook[3] instead, as it invokes only once and pipes the updated refs line by line on stdin.

[1] https://sourcehut.org/blog/2019-11-22-what-happens-on-git-push/#following-up-hooks

[2] https://git.sr.ht/~sircmpwn/git.sr.ht/tree/beb2f86a521271110342194e317c1fc5a4b23e6d/gitsrht-update-hook/update.go#L11

[3] https://git-scm.com/docs/githooks#pre-receive

#23 Sources redirect directly to repo if there's only one 3 months ago

Comment by ~amiryal on ~sircmpwn/hub.sr.ht

I would wait with this one until #15 (Add project backlinks to resources on each service) is done.

#350 Crash when deleting last message in view 5 months ago

Comment by ~amiryal on ~sircmpwn/aerc2

It is possible that I was using a slightly older master (2fcd77f10). Now I am using latest master (f3dbecaaea16) with my latest patch applied (https://lists.sr.ht/~sircmpwn/aerc/patches/9902) and I can’t reproduce, either. Sorry for the trouble; will reopen or report again with more reliable information next time. Thanks!

REPORTED RESOLVED INVALID

#207 Always display error messages “above the fold” 5 months ago

Ticket created by ~amiryal on ~sircmpwn/todo.sr.ht

For example, it is easy to miss the message “Comment must be between 3 and 16384 characters” near the bottom of the page, when the view goes to the top of the page on comment submission.

#350 Crash when deleting last message in view 5 months ago

good first ticket removed by ~amiryal on ~sircmpwn/aerc2

#350 Crash when deleting last message in view 5 months ago

good first ticket added by ~amiryal on ~sircmpwn/aerc2

#350 Crash when deleting last message in view 5 months ago

Comment by ~amiryal on ~sircmpwn/aerc2

My short previous experience resolving a panic: runtime error: invalid memory address or nil pointer dereference was pretty smooth, so adding the “good first ticket” label.

#350 Crash when deleting last message in view 5 months ago

bug added by ~amiryal on ~sircmpwn/aerc2

#350 Crash when deleting last message in view 5 months ago

Ticket created by ~amiryal on ~sircmpwn/aerc2

panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x64 pc=0x8c7f54]

goroutine 1 [running]:
git.sr.ht/~sircmpwn/aerc/commands/msg.findNextNonDeleted(0xc00078cddc, 0x1, 0x1, 0xc0000e3040, 0xc0006fa380)
        /home/user/src/aerc/commands/msg/delete.go:81 +0x94
git.sr.ht/~sircmpwn/aerc/commands/msg.Delete.Execute(0xc0001a80a0, 0xc0006fa360, 0x1, 0x1, 0x1, 0xc0000bde30)
        /home/user/src/aerc/commands/msg/delete.go:58 +0x1d2
git.sr.ht/~sircmpwn/aerc/commands.(*Commands).ExecuteCommand(0xc0000c6168, 0xc0001a80a0, 0xc0006fa360, 0x1, 0x1, 0xab6860, 0xc0006fa370)
        /home/user/src/aerc/commands/commands.go:66 +0xa7
main.execCommand(0xc0001a80a0, 0xc000388000, 0xc0006fa360, 0x1, 0x1, 0xc0006fa360, 0xc0007aa720)
        /home/user/src/aerc/aerc.go:58 +0xc7
main.main.func2(0xc0006fa360, 0x1, 0x1, 0x1, 0x1)
        /home/user/src/aerc/aerc.go:154 +0x57
git.sr.ht/~sircmpwn/aerc/widgets.(*Aerc).BeginExCommand.func1(0xc00078cdb0, 0x6)
        /home/user/src/aerc/widgets/aerc.go:382 +0x83
git.sr.ht/~sircmpwn/aerc/widgets.(*ExLine).Event(0xc0002be140, 0xab5a60, 0xc00024e920, 0xc00024e920)
        /home/user/src/aerc/widgets/exline.go:79 +0x131
git.sr.ht/~sircmpwn/aerc/widgets.(*Aerc).Event(0xc0001a80a0, 0xab5a60, 0xc00024e920, 0x934501)
        /home/user/src/aerc/widgets/aerc.go:202 +0x4c1
git.sr.ht/~sircmpwn/aerc/widgets.(*Aerc).simulate(0xc0001a80a0, 0xc0000bf940, 0x8, 0x8)
        /home/user/src/aerc/widgets/aerc.go:195 +0x8d
git.sr.ht/~sircmpwn/aerc/widgets.(*Aerc).Event(0xc0001a80a0, 0xab5a60, 0xc000285de0, 0x9583c0)
        /home/user/src/aerc/widgets/aerc.go:218 +0x3e8
git.sr.ht/~sircmpwn/aerc/lib/ui.(*UI).Tick(0xc000388000, 0xa16600)
        /home/user/src/aerc/lib/ui/ui.go:92 +0x190
main.main()
        /home/user/src/aerc/aerc.go:184 +0x5da

One way to reproduce: filter the folder message list such that only one message is in view; delete the message.

#349 Show attachment file names 5 months ago

tui added by ~amiryal on ~sircmpwn/aerc2