#173 Warn if username is invalid in DNS 6 months ago

Ticket created by ~ancarda on ~sircmpwn/meta.sr.ht

https://lists.sr.ht/~sircmpwn/sr.ht-discuss/%3C6fe2f6d8-c613-df86-7108-704e34853679%40posteo.net%3E

A user ~phi1_h created a SourceHut Site which does not load on some devices. It's possible it's due to the underscore, which is not allowed in DNS.

SourceHut should warn or reject if a username is invalid in DNS.

• Find the most relevant RFC.
• Implement a function to check users who are signing up with a username that isn't permitted.

A warn seems fine to me, as they may never want to use SourceHut Pages, and if they do they could change their username (#118)

#1 RandomBytes class 6 months ago

~ancarda assigned ~ancarda to #1 on ~ancarda/high-test-coverage

#1 RandomBytes class 6 months ago

1.1 added by ~ancarda on ~ancarda/high-test-coverage

#1 RandomBytes class 6 months ago

Ticket created by ~ancarda on ~ancarda/high-test-coverage

Create an interface and set of implementations for random_bytes that follows how random_int is handled.

#2 Check for valid XML that's not a clover file 6 months ago

~ancarda assigned ~ancarda to #2 on ~ancarda/coverage-enforcer

#2 Check for valid XML that's not a clover file 6 months ago

1.1 added by ~ancarda on ~ancarda/coverage-enforcer

#3 Subclass RuntimeException 6 months ago

~ancarda assigned ~ancarda to #3 on ~ancarda/coverage-enforcer

#3 Subclass RuntimeException 6 months ago

1.1 added by ~ancarda on ~ancarda/coverage-enforcer

#3 Subclass RuntimeException 6 months ago

Ticket created by ~ancarda on ~ancarda/coverage-enforcer

The loadXML function should throw exceptions like FileNotFoundException and ParseFailureException.

The assert functions should throw InsufficientCoverageException.

Something like this:

digraph G {
    FileNotFoundException -> LoadFailureException;
    ParseFailureException -> LoadFailureException;
    
    LoadFailureException -> RuntimeException;

    InsufficientCoverage -> RuntimeException;
}

#2 Check for valid XML that's not a clover file 6 months ago

Ticket created by ~ancarda on ~ancarda/coverage-enforcer

The loadXML function should check if the XML file looks like a clover XML file -- that is it contains project and inside, metrics with the right attributes (statements and coveredstatements)