~anteater/mms-stack-bugs#20: build error: implicit conversion

Excited to try this!

On latest mobian, running somewhat off the steps in #16:

sudo apt install gcc dbus make automake libtool libglib2.0-dev libdbus-1-dev libudev-dev
sudo apt install make gcc automake libtool-bin autotools-dev libudev-dev libdbus-1-dev libglib2.0-dev libcairo2-dev libjpeg-dev libgif-dev libpango1.0-dev libgdk-pixbuf2.0-dev librust-atk-dev librust-gdk-dev libsqlite3-dev
cd
mkdir mms
cd mms
git clone https://git.sr.ht/~anteater/ofono
cd ofono
sudo apt install mobile-broadband-provider-info
./bootstrap-configure && make && sudo make install

It builds for a while, but then it hits:

  CC       src/simutil.o
  CC       src/smsutil.o
src/smsutil.c: In function ‘sms_text_prepare_with_alphabet’:
src/smsutil.c:3594:8: error: implicit conversion from ‘enum sms_alphabet’ to ‘enum gsm_dialect’ [-Werror=enum-conversion]
 3594 |        alphabet, &used_locking,
      |        ^~~~~~~~
cc1: all warnings being treated as errors
make[1]: *** [Makefile:4064: src/smsutil.o] Error 1
make: *** [Makefile:2369: all] Error 2

Status: RESOLVED BY_DESIGN
Submitter: ~amindfv
Assigned to: No-one
Submitted: 4 years ago
Updated: 4 years ago
Labels: mmsd ofono

~anteater 4 years ago

It looks like your gcc is new enough that -Werror hits something new. I'll see if it's fixed upstream and rebase my ofono branch.

If upstream doesn't have it fixed already I'll add a patch to my fork; it should be trivial.

~johanvandegriff 4 years ago

For now I just disabled -Werror in the Makefile after running ./bootstrap-configure but before running make.

~anteater added ofono 4 years ago

~amindfv 4 years ago

Can confirm that ~johanvandegriff 's workaround allows it to successfully compile. This issue is also present (and fixable with the same workaround) when building mmsd.

~anteater added mmsd 4 years ago

~anteater REPORTED BY_DESIGN 4 years ago

This is caused by enabling maintainer mode when configuring (as the bootstrap-configure script does), which is not recommended. The solution is to avoid that script and use ./bootstrap to bootstrap and then run ./configure with your preferred arguments.