~bptato/chawan#1: 
man directories not created, wrong manpage mode

The install target doesn't seem to create the needed directories. Since -D is not passed to install, if, for example, /usr/local/share/man/man5 doesn't exist, all files under .obj/man ending with .5 will be copied to a file /usr/local/share/man/man5, with each install overwriting the contents of that file.

Also, manpages are copied with the mode 655, equal to rw-r-xr-x, which is very weird. Usually for regular files 644 (=rw-r--r--) is used, and 755 (=rwxr-xr-x) for executables and directories.

I propose either using mkdir to create the necessary directories if they don't exist, or passing -D to install. If the latter is applied, then the filenames also need to be repeated in the destination argument:

install -Dm644 "$(OBJDIR)/man/cha-config.5" "$(DESTDIR)$(manprefix5)/cha-config.5"
Status
RESOLVED FIXED
Submitter
~strahinja
Assigned to
No-one
Submitted
1 year, 3 months ago
Updated
4 months ago
Labels
No labels applied.

~bptato 1 year, 3 months ago

Thank you for the suggestions :)

Should be fixed in commit 0630fcf.

~bptato REPORTED FIXED 4 months ago

(closing old tickets)

a1ex@dismail.de referenced this from #44 15 days ago

Register here or Log in to comment, or comment via email.