~delthas/senpai#172: 
broken irc parsing on lines with source omitted

senpai emits "Received corrupt message" errors when receiving lines without a source/prefix:

Received corrupt message "NOTICE * :*** Looking up your hostname and checking ident": missing message prefix

clients MUST be able to handle this according to modern:

Servers MAY include a source on any message, and MAY leave a source off of any message. Clients MUST be able to process any given message the same way whether it contains a source or does not contain one.

Status
RESOLVED FIXED
Submitter
~xfnw
Assigned to
No-one
Submitted
8 months ago
Updated
6 months ago
Labels
No labels applied.

~xfnw 8 months ago

on closer inspection, the parsing is fine, the problem is the handling in irc/session.go rejecting messages without a source in a bunch of places

~delthas 8 months ago

Hi, out of curiosity where did you encounter such messages? Which network?

~xfnw 8 months ago

it'll happen on anything that uses ngircd, like irc.barton.de

~delthas REPORTED FIXED 6 months ago

delthas referenced this ticket in commit 89dc108.

~xfnw 6 months ago

thanks!

Register here or Log in to comment, or comment via email.