~deuill assigned ~deuill to #222 on ~nicoco/slidge
Comment by ~deuill on ~nicoco/slidge-whatsapp
I haven't had any deadlocks for a while, and am pretty happy the changes above improved reliability and responsiveness -- I'm closing this, but we can re-open if we get any more reports.
REPORTED
RESOLVED CLOSEDComment by ~deuill on ~nicoco/slidge-whatsapp
Is this closable?
Comment by ~deuill on ~nicoco/slidge-whatsapp
I've not really seen this myself, and it's hard to delve in without more context here -- AFAICT this might've been an intermittent issue with fetching encryption keys, all of which is handled internally by https://github.com/tulir/whatsmeow. There's a few similar tickets on their tracker, so I'll assume it's their bug.
REPORTED
RESOLVED NOT_OUR_BUGComment by ~deuill on ~nicoco/slidge-whatsapp
This was brought up to the same UX as the official client in https://git.sr.ht/~nicoco/slidge-whatsapp/commit/103639975b882b37b54605952b5a188853c586e3, unfortunately without the additional context of original sender/group, which is unavailable to us in any case.
REPORTED
RESOLVED CLOSEDComment by ~deuill on ~nicoco/slidge-whatsapp
This was implemented in https://git.sr.ht/~nicoco/slidge-whatsapp/commit/c7bd2600d5ebf4e64a9fceced546cdb2cdfe6fd0. Seems that WhatsApp doesn't use OEmbed at all, and seemingly only supports YouTube (and maybe a few other sites I'm not aware of).
REPORTED
RESOLVED CLOSEDbug added by ~deuill on ~nicoco/slidge
Ticket created by ~deuill on ~nicoco/slidge
It appears that slow gateway bring-up can cause tasks for
BaseGateway.fetch_avatar()
to time out, which then cause a (controlled) gateway crash, the only workaround for which appears to (currently) be the complete removal of all stored state for Slidge.A truncated and redacted log-file which shows relevant/interesting parts of gateway bring-up:
https://paste.sr.ht/~deuill/544bf8db0d6e0746255a492362da7e2dca7dbad7
This happens as of Slidge version 0.2.0, or commit 49fc781.
Comment by ~deuill on ~nicoco/slidge-whatsapp
Noted that even on the official client, the original author isn't mentioned anywhere -- messages are simply marked as being forwarded (and have
IsForwarded: 1
set in their context info). That said it might be good to have parity with the official UX here.