Ticket created by ~dhruvin on ~whereiseveryone/guixrus
I've recently removed lint task from sourcehut build manifest since there were just too many warnings. To lower the barrier to entry, we don't disallow packages with lint warnings.
I propose to have a git pre-commit hook that warns about lint warning on a contributors local machine. This has much better feedback loop than awaiting build servers' job completion.
To do so, one would need to figure out a way to map added/changed files to added/changed packages.
Comment by ~dhruvin on ~whereiseveryone/guixrus
package
record has aproperty
field which should be an alist. It has no meaning to guix package derivation but is used by tooling around guix (e.g. guix refresh, and guix lint).We can do this instead of having additional fields to package record:
(package ... (properties '((guixrus-tags . ("tag1" "tag2")))))
Comment by ~dhruvin on ~whereiseveryone/guixrus
I agree that peer review should only be required for when one's not certain.
We should ask (not require) peers to make sure new packages are linted before pushing to master. This will also make it easier for upstream to review and apply patches of these packages if/when sent upstream.
~whereiseveryone assigned ~dhruvin to #116 on ~whereiseveryone/guixrus
Comment by ~dhruvin on ~whereiseveryone/guixrus
ef8413f adds hut.
REPORTED
RESOLVED IMPLEMENTEDComment by ~dhruvin on ~whereiseveryone/guixrus
~emersion has released hut v0.1.0.
It includes patches for
hut pages publish
, which will help simplify our build manifest. I tried packaging it withguix import go git.sr.ht/~emersion/hut@0.1.0
for "guix" channel, but./pre-inst-env guix build ...
goes OOM (even with 8G RAM) when trying to build it.
Comment by ~dhruvin on ~whereiseveryone/guixrus
e5283f4 implements it.
REPORTED
RESOLVED FIXEDon ~whereiseveryone/builds.sr.ht-guix
CONFIRMED
RESOLVED IMPLEMENTEDon ~whereiseveryone/builds.sr.ht-guix
CONFIRMED
RESOLVED FIXEDon ~whereiseveryone/builds.sr.ht-guix
CONFIRMED
RESOLVED IMPLEMENTED