Comment by ~eliasnaur on ~eliasnaur/gio
Elias Naur referenced this ticket in commit e3ef98d.
REPORTED
RESOLVED FIXEDComment by ~eliasnaur on ~eliasnaur/gio
I don't remember the intention, but I suppose the offending change can be reverted now that topmost handlers act as backstops for
key.Event
s which is a better behaviour.FWIW, I can't seem to find this
key-input-tree
example in main.go. What did I miss?
Comment by ~eliasnaur on ~eliasnaur/gio
I forgot about NavigationColor and StatusColor. It could be re-purposed to adjust the title bar color, but would we want that color change for the other platforms?
on ~eliasnaur/gio
Gio already have NavigationColor and StatusColor, which is used on Android (and JS). In that case that is a system call, and not "in-gio".
Maybe, that function (NavigationColor) can be used to change color on Wayland.
-- Lucas Rodrigues inkeliz@inkeliz.com
On Fri, May 26, 2023, at 11:11 PM, ~eliasnaur wrote:
I'd rather not add the ability to change the color, because then there will be demand to change the color for other platforms. If users want to customize the title bar, they should redo it completely by disabling the default decorations (
app.Decorated
).I'm not against changing the default, though. Would you like to send a patch for review?
-- View on the web: https://todo.sr.ht/~eliasnaur/gio/500#event-239788
Comment by ~eliasnaur on ~eliasnaur/gio
I'd rather not add the ability to change the color, because then there will be demand to change the color for other platforms. If users want to customize the title bar, they should redo it completely by disabling the default decorations (
app.Decorated
).I'm not against changing the default, though. Would you like to send a patch for review?
Comment by ~eliasnaur on ~eliasnaur/gio
Sure, let's drop it.
on ~eliasnaur/gio
I replicated the behavior and bisected it to this commit:
28c206fc78c76b1481fc3ed4c28ce3562ce424ba is the first bad commit commit 28c206fc78c76b1481fc3ed4c28ce3562ce424ba Author: Elias Naur <mail@eliasnaur.com> Date: Wed Jul 20 10:37:28 2022 +0200 io/router: try all handlers if a key don't match the focus ancestor tree When a key.InputOp is focused, a key.Event is matched to it and its ancestors. If there is no focus, every handler is matched. This change always matches to every handler, after checking the focus and its ancestors. Signed-off-by: Elias Naur <mail@eliasnaur.com> io/router/key_test.go | 4 ++-- io/router/router.go | 6 ++++++ 2 files changed, 8 insertions(+), 2 deletions(-)
Reading the commit description, it seems that this behavior is deliberate, but I lack the context on why it was made. ~eliasnaur can you comment on this?
Comment by ~eliasnaur on ~eliasnaur/gio
REPORTED
RESOLVED FIXEDComment by ~eliasnaur on ~eliasnaur/gio
Elias Naur referenced this ticket in commit 8571b25.
Comment by ~eliasnaur on ~eliasnaur/gio
Please try out https://lists.sr.ht/~eliasnaur/gio-patches/patches/41069.