~emersion 1 year, 3 months ago

Ah, it seems like kanshi will try to match " MSI MAG161V AA1H010800597" and " Q27G2G4 0x000064B2" (yes, with a leading space). That's not very nice indeed.

We should probably update match_profile_output to use the string "Unknown" just like Sway does to avoid confusion.

~emersion added bug 1 year, 3 months ago

~detegr 1 year, 3 months ago

I have the same issue with following profile:

profile "home" {
    output eDP-1 disable
    output "ViewSonic Corporation XG2402 SERIES" enable mode 1920x1080@144 scale 1.0
}

Outputs are:

Output eDP-1 'Unknown 0x0791 0x00000000'
Output DP-4 'ViewSonic Corporation XG2402 SERIES V4K180200581' (focused)

Changing the profile to have the exact match it matches correctly:

profile "home" {
    output eDP-1 disable
    output "ViewSonic Corporation XG2402 SERIES V4K180200581" enable mode 1920x1080@144 scale 1.0
}

This behavior seems to be different from version 1.2, is it by design or is this a bug?

~emersion 1 year, 3 months ago

The man page says:

The criteria can either be an output name, an output description or "*".

So yes, this was a bug in kanshi which got fixed.

Soumya Ranjan Patnaik 1 year, 3 months ago · edit

I have a similar issue. I have two monitors with me. swaymsg -t get_outputs gets me the following two monitors:

Output eDP-1 'Najing CEC Panda FPD Technology CO. ltd 0x0050 Unknown'
Output HDMI-A-1 'LG Electronics LG ULTRAGEAR 204NTDV9E466' (focused)

I'm using this profile in my config.

profile {
    output 'LG Electronics LG ULTRAGEAR 204NTDV9E466' mode
2560x1440@96.005Hz position 1920,0 transform normal scale 1
    output 'Najing CEC Panda FPD Technology CO. ltd 0x0050 Unknown'
mode 1920x1080@120.003Hz position 0,1077 transform normal scale 1
}

But I get the output

no profile matched

If I change the same configuration to

profile {
    output 'LG Electronics LG ULTRAGEAR 204NTDV9E466' mode
2560x1440@96.005Hz position 1920,0 transform normal scale 1
    output eDP-1 mode 1920x1080@120.003Hz position 0,1077 transform
normal scale 1
}

The profile starts working. It appears that using names with Unknown serial doesn't currently work.

~adigitoleo 1 year, 2 months ago

Forgot to follow up: using exact matches works for me, without spaces, even if they contain "Unknown", e.g.

profile home {
    output "Unknown Q27G2G4 0x000064B2" position -2179,0 scale 1.175 mode 2560x1440@143.9Hz
    output "Unknown MSI MAG161V AA1H010800597" position 0,360 scale 1.4
}

So yes, this was a bug in kanshi which got fixed.

Can you clarify what you mean by this: was it a bug that partial names were matching before, or is it a bug that only exact names are matching? I'm happy switching to exact names in the config, just making sure.

~emersion 1 year, 2 months ago

Yeah, what I mean is that the partial matching in previous versions of kanshi was unintentional.

~emersion 1 year, 2 months ago

Simon Ser referenced this ticket in commit eddaeac.

~jokeyrhyme 1 year, 1 month ago

Is there a way to get kanshi 1.3.0 to match make and model without serial number? My office provides hotdesks with many of the same monitor, and I'd prefer to not have to add serial numbers for every monitor to my configuration

I'd also generally prefer to not store serial numbers in my dotfiles (which are a public git repository)

~emersion 1 year, 1 month ago

~jokeyrhyme, this would be #49.