~emersion/soju#102: 
Replace mentions of the user upstream nick in incoming upstream messages

In multi-upstream mode, if someone mentions a user and his upstream nick is different frm his donwstream nick, he won't get any highlight notification from his client.

Replace mentions of the user upstream nick with the downstream nick.

eg

upstream incoming: PRIVMSG foo #bar :sojuupstream: hi
downstream outcoming: PRIVMSG foo/server #bar :sojudownstream: hi
Status
REPORTED
Submitter
~delthas
Assigned to
No-one
Submitted
2 months ago
Updated
2 months ago
Labels
enhancement

~taiite 2 months ago

(how) would you handle this case:

I'm nicked "taiite" on one of my upstreams, and sometimes people call me "taiites". I want it to be a highlight.

Also, you don't want to replace in-word nicks, since you can fall on case like "dan" and "Daniel" being on the same channel.

~delthas 2 months ago

I think we should only support whole-word matches. So if people call you by your nick without spelling it properly or by adding a few letters it won't be replaced. If you expect to be called taiites in the first place you could add a rule in your client I guess

~emersion 2 months ago

I'm nicked "taiite" on one of my upstreams, and sometimes people call me "taiites". I want it to be a highlight.

I don't find this very compelling. Just configure your client to highlight on other words.

Also, you don't want to replace in-word nicks, since you can fall on case like "dan" and "Daniel" being on the same channel.

The current highlight detection code checks this IIRC.

But I thought we replaced highlights coming from upstream already? Or was it highlights coming from downstream? Anyways, that highlight replacing doesn't check whether we're in the middle of a word or not.

~delthas 2 months ago

We currently only do highlights coming from donwstream

Register here or Log in to comment, or comment via email.