Creating new networks, with the same addresses but different names, can cause problems with BouncerServ internals, such as network delete ircs://irc.libera.chat still being valid.
Other issues arise with a bouncer service i was using where error: context deadline exceeded started appearing when using network delete on the problematic network.
There also seems to be some soju bugs such as
2024/11/22 12:55:23 user "sewn": downstream "127.0.0.1:34714": failed to handle new registered connection: FAIL BOUNCER INVALID_NETID 3 :Unknown network IDwhich i am not sure if it is a result from this issue.
What would you expect to happen? Right now I think it deletes the first network which matches.
My gut feeling is that "context deadline exceeded" errors are unrelated to having multiple networks with the same name.
"Unknown network ID" are usually indicative of client bugs: they don't handle network deletion events and try reconnecting.
With two networks sharing the same address, one with an explicit name and one without, I'd expect BouncerServ commands such as
network delete <addr>to resolve to the network with no name, but instead resolves to the one with a name. It should prefer the name, and fallback to address, unclarified in the soju man page.The errors (
context deadline exceeded) only started appearing after the duplicate(?) network creations.
The address is matched by design, this is a feature that I don't want to get rid of. Even if we wouldn't do that, there would be ambiguous cases.
if that's the case, then I guess this issue can be closed as a 'will not fix' (not sure how sr.ht issues work). The other bugs mentioned here are either beyond the scope of soju or need proper reenactment .