Don't save invalid nicknames

soju seems to save the nickname in the DB on /nick, even if the server replies with an error.

This results in failures to connect the next time soju needs to.

When receiving a NICK from downstream, soju should wait for upstream to ack the nick before saving it in the database.

Assigned to
6 months ago
5 months ago
No labels applied.

~emersion 6 months ago

I don't think so.

~taiite referenced this from #66 6 months ago

~emersion REPORTED BY_DESIGN 5 months ago

So far, all of the database content only depends on what the user chose. If the user joins a channel, the channel is immediately saved to the DB, even if a key is required. This prevents some surprises that could be caused by transient upstream errors and helps keep things simple (the upstream doesn't decide what should be in the DB).

Register here or Log in to comment, or comment via email.