#250 searcher: don't check module-name as-is before converting `.` to path separator 3 months ago

Comment by ~hedy on ~technomancy/fennel

awesome. thank you!

#250 searcher: don't check module-name as-is before converting `.` to path separator 3 months ago

Ticket created by ~hedy on ~technomancy/fennel

see: https://git.sr.ht/~technomancy/fennel/tree/c057f58216c47a968709c08d4907685d2cff77c3/item/src/fennel/specials.fnl#L1247

(let [pathsepesc (escapepat pkg-config.pathsep)
        pattern (: "([^%s]*)%s" :format pathsepesc pathsepesc)
        no-dot-module (modulename:gsub "%." pkg-config.dirsep)
        fullpath (.. (or ?pathstring utils.fennel-module.path)
                     pkg-config.pathsep)]
    (fn try-path [path]
      (let [filename (path:gsub (escapepat pkg-config.pathmark) no-dot-module)
            filename2 (path:gsub (escapepat pkg-config.pathmark) modulename)]
        (case (or (io.open filename) (io.open filename2))
          file (do
                 (file:close)
                 filename)
          _ (values nil (.. "no file '" filename "'")))))

it checks modulename which was the value of that in (require :modulename) as well as as no-dot-module, but returns only the filename for no-dot-module if either of them works.

this presents an issue when the module contains a dot. on requiring module.name, it checks module/name.fnl, and module.name.fnl if only the latter exists, the filename is passed to dofile, which then raises runtime error on failing to io.open it.

checking module.name.fnl (rather than just module/name.fnl is also inconsistent with lua's behaviour.

use case: custom support for importing modules with dot in their names: https://git.sr.ht/~hedy/fssg/tree/67b30cdac878cc3b8809379abe1d2f23751f854b/item/fix-searcher.fnl

#32 file:// protocol 5 months ago

priority added by ~hedy on ~hedy/gelim

#40 gopher queries 5 months ago

Comment by ~hedy on ~hedy/gelim

~hedy referenced this ticket in commit 22bcbe7.

REPORTED RESOLVED CLOSED

#40 gopher queries 5 months ago

on ~hedy/gelim

~hedy referenced this ticket in commit 22bcbe7.

#40 gopher queries 5 months ago

support added by ~hedy on ~hedy/gelim

#40 gopher queries 5 months ago

Ticket created by ~hedy on ~hedy/gelim

for now I can only see a mention of the type 7 item in the rfc "FullText search" query but have no idea how this is submitted or how it should be handled.

gopher://gopher.black:70/0/archive/rfc/1436.txt

#25 gopher protocol 5 months ago

on ~hedy/gelim

~hedy referenced this ticket in commit c29e1df.

#25 gopher protocol 5 months ago

Comment by ~hedy on ~hedy/gelim

~hedy referenced this ticket in commit c29e1df.

REPORTED RESOLVED CLOSED

#39 disable centering with maxWidth = 0 5 months ago

easy added by ~hedy on ~hedy/gelim