~ihabunek

Zagreb, Croatia

Trackers

~ihabunek/test

Last active 7 months ago

#156 Handle user/ticket mentions in the ticket body a month ago

Comment by ~ihabunek on ~sircmpwn/todo.sr.ht

This has been implemented.

#166 Link ticket mentions a month ago

on ~sircmpwn/todo.sr.ht

REPORTED RESOLVED IMPLEMENTED

#156 Handle user/ticket mentions in the ticket body a month ago

Comment by ~ihabunek on ~sircmpwn/todo.sr.ht

Further discussion on the mailing list: https://lists.sr.ht/~sircmpwn/sr.ht-dev/%3C20190327150946.GA24438%40groucho.local%3E

#156 Handle user/ticket mentions in the ticket body 2 months ago

Comment by ~ihabunek on ~sircmpwn/todo.sr.ht

that plan almost looks good but it ticketid shouldn't be set to the new ticket it should be set to the mentioned ticket and a new field added, like ticketmentionid, referring to the source of the mention then commentid would be null if ticket_id != the ticket mentioned, then the mentioning won't show up in that ticket's events

#166 Link ticket mentions 2 months ago

Comment by ~ihabunek on ~sircmpwn/todo.sr.ht

OK, Drew already implemented the links, but they don't work with qualified ticket references.

#166 Link ticket mentions 2 months ago

Comment by ~ihabunek on ~sircmpwn/todo.sr.ht

For example, these should link to this issue:

  • #166
  • todo.sr.ht#166
  • ~sircmpwn/todo.sr.ht#166

#166 Link ticket mentions 2 months ago

Ticket created by ~ihabunek on ~sircmpwn/todo.sr.ht

Ticket mentions are implemented, but not shown in rendered markdown.

#156 Handle user/ticket mentions in the ticket body 2 months ago

Comment by ~ihabunek on ~sircmpwn/todo.sr.ht

Slight problem here. Currently, when a ticket is mentioned in a comment, the Event which is created will have ticket set to the mentioned ticket, and comment set to the comment where it was mentioned.

However, if a ticket is mentioned in another ticket body, we need to store both the ticket being mentioned, as well as the ticket whose body contains the mention.

Should I add a Event.mentioned_ticket field and migrate the data for existing events or do you have a better idea?

#161 Label text color is inconsistent 2 months ago

Comment by ~ihabunek on ~sircmpwn/todo.sr.ht

I cannot reproduce this, getting the same foreground and background colours on both views.

For example:

#162 Mentions break URLs 2 months ago

~sircmpwn assigned ~ihabunek to #162 on ~sircmpwn/todo.sr.ht