Comment by ~ihabunek on ~sircmpwn/todo.sr.ht
This has been implemented.
Comment by ~ihabunek on ~sircmpwn/todo.sr.ht
Further discussion on the mailing list: https://lists.sr.ht/~sircmpwn/sr.ht-dev/%3C20190327150946.GA24438%40groucho.local%3E
Comment by ~ihabunek on ~sircmpwn/todo.sr.ht
that plan almost looks good but it ticketid shouldn't be set to the new ticket it should be set to the mentioned ticket and a new field added, like ticketmentionid, referring to the source of the mention then commentid would be null if ticket_id != the ticket mentioned, then the mentioning won't show up in that ticket's events
Comment by ~ihabunek on ~sircmpwn/todo.sr.ht
OK, Drew already implemented the links, but they don't work with qualified ticket references.
Comment by ~ihabunek on ~sircmpwn/todo.sr.ht
For example, these should link to this issue:
- #166
- todo.sr.ht#166
- ~sircmpwn/todo.sr.ht#166
Ticket created by ~ihabunek on ~sircmpwn/todo.sr.ht
Ticket mentions are implemented, but not shown in rendered markdown.
Comment by ~ihabunek on ~sircmpwn/todo.sr.ht
Slight problem here. Currently, when a ticket is mentioned in a comment, the Event which is created will have
ticketset to the mentioned ticket, andcommentset to the comment where it was mentioned.However, if a ticket is mentioned in another ticket body, we need to store both the ticket being mentioned, as well as the ticket whose body contains the mention.
Should I add a
Event.mentioned_ticketfield and migrate the data for existing events or do you have a better idea?
Comment by ~ihabunek on ~sircmpwn/todo.sr.ht
I cannot reproduce this, getting the same foreground and background colours on both views.
For example:
- list view: https://i.imgur.com/ox5cUYe.png
- detail view: https://i.imgur.com/DJ3rTg6.png
