~ireas/nitrokey-rs#2: Use only one command in Device::get_firmware_version

~ireas/nitrokey-rs#2:

Use only one command in Device::get_firmware_version

Currently, we determine the firmware version with NK_get_major_firmware_version and NK_get_minor_firmware_version, issuing two commands to the Nitrokey device. This could be replaced by a single command.

Status: REPORTED
Submitter: ~ireas
Assigned to: No-one
Submitted: 3 years ago
Updated: 3 years ago
Labels: good first issue

~ireas added good first issue 3 years ago

~ireas 3 years ago

To implement this, we should move the implementation from src/device/mod.rs to the device modules. For Librem and Pro devices, we can use get_status()?.firmware_version. For Storage devices, we can use get_storage_status()?.firmware_version.