~jack 2 years ago

https://git.sr.ht/~jack/nix-freeze-tree/tree/526efaa834de294b823235f6a9bfa344e2fe4461/item/src/NixBuilder.hs#L106-112 is where derivation names are rewritten. I suspect replaceLeadingDot will need replacing with a function that does more mangling. Would you like to try and send a patch for this?

Gianluca Stivan 2 years ago · edit

i've given it a try this weekend, but unfortunately it's not that simple.

imagine the you have a folder named "hi@hello". the generated code would be

import ./hi@hello { inherit stdend; }

this doesn't work, and as far as i know quoting the path doesn't help. so the only solution i can think is to generate a single default.nix at the root level...

~jack 2 years ago

In such situations, I'd try emitting code that calls the path builtin: https://nixos.org/manual/nix/stable/expressions/builtins.html#builtins-path

An enrichment of the built-in path type, based on the attributes present in args. All are optional except path:

• name
  The name of the path when added to the store. This can used to reference paths that have nix-illegal characters in their names, like @.

Gianluca Stivan referenced this from #8 2 years ago

Gianluca Stivan 2 years ago · edit

That part I’ve already fixed. What’s wrong (and cannot be fixed afaik) is

myfolder/default.nix myfolder/some@other/default.nix

As far as I know there’s no way to import such a structure in nix due to limitations on how nix does parsing.

Thanks!

Il giorno 20 ago 2022, alle ore 13:48, ~jack outgoing@sr.ht ha scritto:

In such situations, I'd try emitting code that calls the path builtin: https://nixos.org/manual/nix/stable/expressions/builtins.html#builtins-path

An enrichment of the built-in path type, based on the attributes present in args. All are optional except path:

• name
  The name of the path when added to the store. This can used to reference paths that have nix-illegal characters in their names, like @.

-- View on the web: https://todo.sr.ht/~jack/nix-freeze-tree/8#event-201776

~jack 2 years ago

I believe that this is fixable, because I ran nix-freeze-tree over a little test directory and made the following changes:

• When importing a directory, we need to generate something like paths = { "bar@baz" = import (./. + "/bar@baz") { inherit stdenv; }; };
• When emitting the default.nix for a directory with @ in its name, we need to not have illegal characters in the name field of the mkDerivation call.

Gianluca Stivan 2 years ago · edit

I stand corrected, I did not know about that trick :)

I've attached a patch that seems to work on my machine. It doesn't support symlinks, but I guess that's a separate problem.

Thanks a lot for the advice.

On Sat, Aug 20, 2022, at 14:23, ~jack wrote:

I believe that this is fixable, because I ran nix-freeze-tree over a little test directory and made the following changes:

• When importing a directory, we need to generate something like paths = { "bar@baz" = import (./. + "/bar@baz") { inherit stdenv; }; };
• When emitting the default.nix for a directory with @ in its name, we need to not have illegal characters in the name field of the mkDerivation call.

-- View on the web: https://todo.sr.ht/~jack/nix-freeze-tree/8#event-201780

Gianluca Stivan referenced this from #8 2 years ago

Gianluca Stivan referenced this from #8 2 years ago

Gianluca Stivan 2 years ago · edit

Seems like I cannot attach documents.

https://pastebin.com/09ZDLqP1

On Sat, Aug 20, 2022, at 14:55, Gianluca Stivan wrote:

I stand corrected, I did not know about that trick :)

I've attached a patch that seems to work on my machine. It doesn't support symlinks, but I guess that's a separate problem.

Thanks a lot for the advice.

On Sat, Aug 20, 2022, at 14:23, ~jack wrote:

I believe that this is fixable, because I ran nix-freeze-tree over a little test directory and made the following changes:

• When importing a directory, we need to generate something like paths = { "bar@baz" = import (./. + "/bar@baz") { inherit stdenv; }; };
• When emitting the default.nix for a directory with @ in its name, we need to not have illegal characters in the name field of the mkDerivation call.

-- View on the web: https://todo.sr.ht/~jack/nix-freeze-tree/8#event-201780 Attachments:

• git-patch

~jack REPORTED IMPLEMENTED 1 year, 3 months ago

Finally got around to looking at this. I rewrote your patch to avoid the regex dependency, and released v0.1.1.0.

Thank you for the report and for your patch.

~jack IMPLEMENTED REPORTED 1 year, 3 months ago

~jack REPORTED FIXED 1 year, 3 months ago