~jkcclemens/PeepingTom#4: 
Possible resource leak in playing sound

Once the (default in my case) sound plays multiple times, sounds and music starts to be skippy on my PC. There seem to be a resource leak.

Fast reproduction steps:

1. Set Cooldown for Sounds to 0 (Optional)

2. Target and untarget your minion (it'll reach a point where the target sound will stop playing).

3. Play a bit (especially on busy areas) and depending on your PC you may experience skippy sounds

Status
RESOLVED FIXED
Submitter
~rreminy
Assigned to
No-one
Submitted
1 year, 3 days ago
Updated
11 months ago
Labels
bug

~jkcclemens 1 year, 3 days ago

I cannot replicate this. Does this only happen when the plugin is installed?

~rreminy 1 year, 2 days ago

Yes, I tested with the plugin alone as well (without any other plugin loaded) and it still does happen.

~maxunit 11 months ago

I can also report the same issue. As soon as I use Peeping Tom with the sound option enabled and run a dungeon as a Tank, as an example, half-way through the dungeon sound gets skippy/stuttery on my end.

~jkcclemens 11 months ago

Still can't reproduce this, but once 1.5.3 is merged, let me know if the issue persists.

~rreminy 11 months ago

Tested from the PR zip file

Its not fixed

I taken a deeper look and it seems to be leaking threads.

https://i.imgur.com/AFKwBvV.png

After the sound plays more times:

https://i.imgur.com/W6mbDfJ.png

At this point sound stopped working.

~jkcclemens REPORTED FIXED 11 months ago

Fixed in 1.5.4.

Register here or Log in to comment, or comment via email.