#147 Bad interaction between objects, imports, and namespaces (regression) 13 days ago

Comment by ~jonsterling on ~jonsterling/forester

Hell yes!! By the way, I see that you committed a bunch of new changes, cool :) Are you still working on that code, or is it alright if I mess around with it a little? (What I'm doing is extremely low priority.)

#147 Bad interaction between objects, imports, and namespaces (regression) 14 days ago

Comment by ~jonsterling on ~jonsterling/forester

I have now pushed my code to forester-5.0-dev.

REPORTED RESOLVED FIXED

#147 Bad interaction between objects, imports, and namespaces (regression) 14 days ago

Comment by ~jonsterling on ~jonsterling/forester

Check out my fix-expansion branch... I haven't tried to run the analysis code, so I can't tell you whether this works, but it has the look of something that will work.

The idea is to instrument the expander with an effect Entered_range of Range.t option and call it every time it descends into a node. A "default" handler just makes this effect a no-op, but the analysis can instead handle this effect as follows:

1. If the received range contains the position we are looking for, halt.
2. Otherwise, resume,

If the effect handlers behave in the way I think they do, this should be a pretty reasonable way to achieve what you are trying to do, at least for now until we come up with something better. Let me know what you think!

#147 Bad interaction between objects, imports, and namespaces (regression) 15 days ago

Comment by ~jonsterling on ~jonsterling/forester

Got an even better idea now... will update you later.

#147 Bad interaction between objects, imports, and namespaces (regression) 15 days ago

Comment by ~jonsterling on ~jonsterling/forester

No worries :)

I'm going to bed soon, but I have written some code that might help. Have a look at this commit: https://git.sr.ht/~jonsterling/ocaml-forester/commit/095bff6c120c51e9cec3cb299e1db181c0449944

This has a lot of duplication, but I think if the idea is right, then I can find a way to unify this with the expander. Let me know what you think!

#147 Bad interaction between objects, imports, and namespaces (regression) 15 days ago

Comment by ~jonsterling on ~jonsterling/forester

Jon Sterling referenced this ticket in commit 838e1ac.

#147 Bad interaction between objects, imports, and namespaces (regression) 15 days ago

release-5.0 added by ~jonsterling on ~jonsterling/forester

#147 Bad interaction between objects, imports, and namespaces (regression) 15 days ago

regression added by ~jonsterling on ~jonsterling/forester

#147 Bad interaction between objects, imports, and namespaces (regression) 15 days ago

bug added by ~jonsterling on ~jonsterling/forester

#147 Bad interaction between objects, imports, and namespaces (regression) 15 days ago

Comment by ~jonsterling on ~jonsterling/forester

Awesome!