#158 Non-YAML file in .builds leads to "Missing image in manifest" 3 years ago

Ticket created by ~jpgrayson on ~sircmpwn/builds.sr.ht

When pushing to a repo with a .builds/ directory, if a non-YAML file is present (e.g. a README file), a "Missing image in manifest" exception is shown and the builds are not triggered.

remote: Traceback (most recent call last):
remote:   File "hooks/post-update", line 58, in <module>
remote:     do_post_update(repo, git_repo, ref)
remote:   File "/usr/lib/python3.6/site-packages/gitsrht/worker.py", line 107, in do_post_update
remote:     submit_builds(repo, git_repo, commit)
remote:   File "/usr/lib/python3.6/site-packages/gitsrht/worker.py", line 57, in submit_builds
remote:     m = Manifest(yaml.safe_load(m))
remote:   File "/usr/lib/python3.6/site-packages/buildsrht/manifest.py", line 62, in __init__
remote:     raise Exception("Missing image in manifest")
remote: Exception: Missing image in manifest

So it appears that all files in the .builds directory are treated as YAML regardless of their extension.

#19 Cannot add tasks for forked GitHub repos 3 years ago

Ticket created by ~jpgrayson on ~sircmpwn/dispatch.sr.ht

When attempting to configuring a task, only non-forked GitHub repos appear in the list of available repos. Thus there does not seem to be a way to configure a new task for a forked repo.


It is somewhat unclear whether this is a bug or a feature. Are cloned repos meant to be prohibited?