Comment by ~ktnb on ~rjarry/aerc
Yes, I can do that. I've not setup the appropriate git email to submit it yet. Once I've got more time, I can do that. Thank you!
Comment by ~ktnb on ~rjarry/aerc
Hi, I'm only bring it up because for pkgsrc I have to remove the .orig before installing (https://github.com/NetBSD/pkgsrc/blob/trunk/mail/aerc/Makefile, line 56). It's not really a huge deal but wanted to bring it up :)
Ticket created by ~ktnb on ~rjarry/aerc
If you are to patch a file inside of
filters/
and that patching creates a.c.orig
file, it will get installed along with other.c
files. This is super minor and nit-picky but it probably shouldn't do this. I'm not 100% sure but I think it has something to do with line 30 ofGNUmakefile
. Thank you!
Ticket created by ~ktnb on ~rjarry/aerc
On NetBSD, we don't need the define in
filters/wrap.c
line 4. If it is left there, we get errors about not havinglocale_t
defined. Removing it will fix these errors. I'm not sure if this same thing happens on other BSDs or not.--- filters/wrap.c.orig 2024-07-21 02:04:53.703418963 +0000 +++ filters/wrap.c @@ -1,7 +1,9 @@ /* SPDX-License-Identifier: MIT */ /* Copyright (c) 2023 Robin Jarry */ +#ifndef __NetBSD__ #define _XOPEN_SOURCE 700 +#endif #include <errno.h> #include <getopt.h> #include <langinfo.h>
Thank you!