#32 Error with Awk 1 year, 5 months ago

Comment by ~l3kn on ~l3kn/org-fc

Hi ~charleshuff, did you find a way to fix this problem?

https://github.com/l3kn/org-fc/issues/67 seems to be the same error but I don't know what might cause it or how to fix it without a manual (require 'org-fc)

#31 Suspending any arbitrary flashcard during a review causes the current flashcard to be buried 1 year, 8 months ago

Comment by ~l3kn on ~l3kn/org-fc

I assume you are in a org-fc review, then navigate to a card different from the current one and use the suspend key binding (bound to org-fc-review-suspend-card)?

The behavior you're seeing is due to an oversight in the design of this function, because I didn't think that people would interact with other cards during the review.

This should not be hard to fix, instead of using the current card of the review session (which might be different from the card at point when using the suspend function), we can get the ID of the flashcard at point and remove that from the session.

#23 Native compilation errors 1 year, 10 months ago

on ~l3kn/org-fc

REPORTED RESOLVED FIXED

#23 Native compilation errors 1 year, 10 months ago

Comment by ~l3kn on ~l3kn/org-fc

That's good to hear!

I also saw the deprecation warning, that will be handled by the next update to org-fc once I figure out how to replicate the old behavior with the new org function.

#23 Native compilation errors 1 year, 10 months ago

Comment by ~l3kn on ~l3kn/org-fc

I've made some changes to how the org-fc files are loaded, can you check if that fixes your compilation errors?

On Emacs 27.1 I'm not getting any anymore.

#30 org-fc-review-next-card erroring when trying to review all 2 years ago

Comment by ~l3kn on ~l3kn/org-fc

Can you check if you get the same error with M-x org-fc-demo? If the demo review works, there might be something wrong with one of your cards, otherwise it's a general problem with the review.

You mention you were able to review one card from the dashboard, was that the same card that failed during org-fc-review-all?

If you haven't done so already, you can enable debug on errors with M-x toggle-debug-on-error, then try to trigger the error again.

#29 Limit cards in an org-fc session 2 years ago

Comment by ~l3kn on ~l3kn/org-fc

I like the idea, where would this limit be set?

Some options that come to mind:

• each time a review session is started (will get tedious over time)
• via a defcustom applying to all review sessions (nil for no limit)
• per review context (maybe in addition to a defcustom for the builtin "buffer" and "all" contexts)

#9 Cached Card Index 2 years ago

Comment by ~l3kn on ~l3kn/org-fc

Even when requiring the cache code later, I ran into the same error trying to use cache-mode on a fresh emacs instance. I'm not sure why this is happening, adding an autoload seems to have fixed it.

#9 Cached Card Index 2 years ago

Comment by ~l3kn on ~l3kn/org-fc

The before-setup-hook runs after a new card is set and before it is set up using the setup function of the card type, so I don't think the session not being defined is the core problem here.

However, I had placed the (require 'org-fc-cache) at a point where the review-with-current-item macro is not yet defined, loading the cache code it would be considered as a function with an undefined argument cur which might explain your error.

Another problem I found is that reviewing single buffers outside of the org-fc-directories doesn't work when cache-mode is active. (not fixed yet)

Did you notice any speedup with your setup when using the cache mode?

The coherence check is a bit of a hack to make sure using the cache doesn't do any damage, I think it could just be moved into the with-current-item macro once we know the cache works as expected (and ideally have some tests for it).

#9 Cached Card Index 2 years ago

Comment by ~l3kn on ~l3kn/org-fc

I've been using the cache mode without problems for the last few days. File titles were missing during the review but that has been fixed with the last commit.