Native compilation errors

In case anyone using the native-comp branch here is a fix for some errors.

The first of which has to do with the macro org-fc-with-point-at-back-heading when called it throws an invalid function error. This is because the function called in the macro, org-fc-back-heading-position needs a (require 'org) in order to be compiled correctly.

Secondly, in order for org-fc-register-type to be used outside the file it, and the variable org-fc-types need to be wrapped in eval-and-compile.

Assigned to
2 years ago
2 years ago

~l3kn 2 years ago

Is there any reason against including these changes in the main org-fc code? I haven't tried native-comp yet but it would be nice if org-fc worked there by default.

~kindablue 2 years ago


I've tested more and I also needed to wrap all the calls to org-fc-register-type like below:

(eval-and-compile (org-fc-register-type

I'd like to check with another who uses native-comp but am unsure how to go about finding them.

-----BEGIN PGP SIGNATURE----- Version: ProtonMail

wsFmBAEBCAAQBQJflKnBCRAh41uws20QlAAKCRAh41uws20QlFhND/9gmnkK iFAnnBwxoOWj4JGwPXV6Of6MiRYrBpyczgsP12kTHz+ara0tbNcJ1MhrBWH2 7R3U5jDoYDMWlpLT4/aCOtrIN69Knq7KU2cvF/U2KPkNKzFt6MMcxUL+0UWH jUkCyVakpwOwWWruws6+FM7zwuRPOCmoToJ8Z0mKfLOZx4Ak7gxz+KFbDoWg lRD3ZI7qLlfiqE6qI73C6orNURLtgKYA5qOql6u0qQozQAhq7XRiZ8akSKWk O2FBhCUhA+2h+N3apzV/F46zo93Pc0Vt0M+yB95f4Q5StKSOL51jEJ82r3vA /Fahihl28QNCtVDDc4WP2+nTBQcj1GKK9WJyJxUzigTFA9ddeHwqTC3kVF2a /MuIu+NMpvEQP93d64o02TqP2uNShPor18Plw0ESlIP813qJLRzpmnaklyAR 9yYeM1hRF5FWM05XzVqGQgTsfF9gGJG23f0zHF8/pe9hPXfEbGkjTJgeHkT5 PKwVJHnTKekp9igJpRxO3fOufgNMsKPo1Ofx3+ynH7Nc1brzhZDLgKP27HJ/ F77hNGKsGSgdY/DWQECttoXI6bCuW4mlXNXULPmxQkkYncGWV1Bh1aUnHgDf 5A1UDT/ln2k2UmaHyZ2Yln63sXUWZBsZMsO2JScWFq6LOepWqjV7dna1pMlZ BLBWUzQi9X3FHCqkMg== =cEdb -----END PGP SIGNATURE-----

~l3kn 2 years ago

I've made some changes to how the org-fc files are loaded, can you check if that fixes your compilation errors?

On Emacs 27.1 I'm not getting any anymore.

~kindablue 2 years ago

I have just tested it and I too am not seeing any significant errors when compiling. Only some surrounding obsolete functions with Org 9.4, but the functionality seems to be okay.

~l3kn 2 years ago*

That's good to hear!

I also saw the deprecation warning, that will be handled by the next update to org-fc once I figure out how to replicate the old behavior with the new org function.

~l3kn REPORTED FIXED 2 years ago

Register here or Log in to comment, or comment via email.