~lattis/muon#27: subproject default_options error: unable to coerce 'false' into a feature

/home/user/rizin_copy/meson.build:482:55: error: unable to coerce 'false' into a feature
482 |   libzip_proj = subproject('libzip', default_options: [
                                                            ^
/home/user/rizin_copy/meson.build:482:17: error: in function subproject
482 |   libzip_proj = subproject('libzip', default_options: [

On the following piece of code:


libzip_dep = dependency('libzip', required: get_option('use_sys_libzip'), static: is_static_build)
if not libzip_dep.found()
  libzip_proj = subproject('libzip', default_options: [
    'default_library=static',
    'static_runtime=@0@'.format(is_static_build),
    'use_sys_openssl=@0@'.format(get_option('use_sys_libzip_openssl')),
  ])
  libzip_dep = libzip_proj.get_variable('libzip_dep')
endif

See https://github.com/rizinorg/rizin/blob/dev/meson.build#L542

Status: RESOLVED FIXED
Submitter: ~xvilka
Assigned to: No-one
Submitted: 4 months ago
Updated: 4 months ago
Labels: No labels applied.

~lattis REPORTED FIXED 4 months ago

Done!

I did notice another error with libzip's options here
option('use_sys_zlib', type: 'boolean', value: 'false', ...)
Meson automatically coerces 'false' -> false, but muon (correctly in my opinion) reports an error that a string is not a bool. 'false' should be changed to false to fix this issue.

~xvilka 4 months ago

Thanks! We fixed that problem in the options file: https://github.com/rizinorg/rizin/commit/e90d770e4a325881e6a10ddc6607b694cf4e7f10