~lukehsiao


#427 segfault in reading headers 2 months ago

Ticket created by ~lukehsiao on ~sircmpwn/aerc2

Using the latest aerc on master (8446d48), I'm seeing the following segfault when opening some emails.

panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x18 pc=0x59cb44]

goroutine 143 [running]:
bufio.(*Reader).fill(0xc000944f00)
    /usr/local/go/src/bufio/bufio.go:100 +0xd4
bufio.(*Reader).Peek(0xc000944f00, 0x1, 0x20, 0xc0009de300, 0xc000a30800, 0x100c00033ad01, 0xc00033add8)
    /usr/local/go/src/bufio/bufio.go:138 +0x4f
github.com/emersion/go-message/textproto.ReadHeader(0xc000944f00, 0x1000, 0x1000, 0xc0017a3000, 0x0, 0x0, 0xc000d141e0)
    /home/lwhsiao/go/pkg/mod/github.com/emersion/go-message@v0.12.0/textproto/header.go:497 +0x7b
git.sr.ht/~sircmpwn/aerc/worker/imap.(*IMAPWorker).handleFetchMessageBodyPart.func1(0xc000a30300, 0xc00033af98, 0x1)
    home/lwhsiao/repos/aerc/worker/imap/fetch.go:92 +0xd8
git.sr.ht/~sircmpwn/aerc/worker/imap.(*IMAPWorker).handleFetchMessages.func1(0xc000954000, 0xc000178500, 0xc0009243f0, 0xc000954060)
    /home/lwhsiao/repos/aerc/worker/imap/fetch.go:169 +0xad
created by git.sr.ht/~sircmpwn/aerc/worker/imap.(*IMAPWorker).handleFetchMessages
    /home/lwhsiao/repos/aerc/worker/imap/fetch.go:165 +0xb6

#364 undefined "errors" during build 6 months ago

Comment by ~lukehsiao on ~sircmpwn/aerc2

That does it. Thanks!

#364 undefined "errors" during build 6 months ago

Ticket created by ~lukehsiao on ~sircmpwn/aerc2

When I try to build the latest master branch (8372e9e), I see the following error. It looks like a dependency was added, but not added to the README or build?

$ make
go build  \
	-ldflags "-X main.Prefix=/usr/local \
	-X main.ShareDir=/usr/local/share/aerc \
	-X main.Version=0.3.0" \
	-o aerc
# git.sr.ht/~sircmpwn/aerc/widgets
widgets/pgpinfo.go:29:5: undefined: "errors".Is
Makefile:20: recipe for target 'aerc' failed
make: *** [aerc] Error 2

#344 panic on findNextNonDeleted 6 months ago

bug added by ~lukehsiao on ~sircmpwn/aerc2

#344 panic on findNextNonDeleted 7 months ago

Ticket created by ~lukehsiao on ~sircmpwn/aerc2

I will occasionally get a panic when I attempt to delete a message that I have used :filter to search for. For example:

  • :filter -f
  • highlight message
  • :delete

Then aerc crashes. Log is below.

panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x64 pc=0x8a38b4]

goroutine 1 [running]:
git.sr.ht/~sircmpwn/aerc/commands/msg.findNextNonDeleted(0xc0016a323c, 0x1, 0x1, 0xc000195d40, 0xc0026a7c50)
	/home/user/repos/aerc/commands/msg/delete.go:84 +0x94
git.sr.ht/~sircmpwn/aerc/commands/msg.Delete.Execute(0xc0000b1cc0, 0xc0026a7c30, 0x1, 0x1, 0x1, 0xc000133790)
	/home/user/repos/aerc/commands/msg/delete.go:61 +0x1d0
git.sr.ht/~sircmpwn/aerc/commands.(*Commands).ExecuteCommand(0xc0000a4190, 0xc0000b1cc0, 0xc0026a7c30, 0x1, 0x1, 0xa79fc0, 0xc0026a7c40)
	/home/user/repos/aerc/commands/commands.go:66 +0xfe
main.execCommand(0xc0000b1cc0, 0xc0001e4140, 0xc0026a7c30, 0x1, 0x1, 0xc0026a7c30, 0xc002656840)
	/home/user/repos/aerc/aerc.go:58 +0xc5
main.main.func2(0xc0026a7c30, 0x1, 0x1, 0x1, 0x1)
	/home/user/repos/aerc/aerc.go:154 +0x57
git.sr.ht/~sircmpwn/aerc/widgets.(*Aerc).BeginExCommand.func1(0xc0016a3210, 0x6)
	/home/user/repos/aerc/widgets/aerc.go:382 +0x83
git.sr.ht/~sircmpwn/aerc/widgets.(*ExLine).Event(0xc002172e00, 0xa792e0, 0xc001f14d60, 0xc001f14d60)
	/home/user/repos/aerc/widgets/exline.go:79 +0x133
git.sr.ht/~sircmpwn/aerc/widgets.(*Aerc).Event(0xc0000b1cc0, 0xa792e0, 0xc001f14d60, 0x90c501)
	/home/user/repos/aerc/widgets/aerc.go:202 +0x4cf
git.sr.ht/~sircmpwn/aerc/widgets.(*Aerc).simulate(0xc0000b1cc0, 0xc0001a8400, 0x8, 0x8)
	/home/user/repos/aerc/widgets/aerc.go:195 +0x9b
git.sr.ht/~sircmpwn/aerc/widgets.(*Aerc).Event(0xc0000b1cc0, 0xa792e0, 0xc001f14c40, 0x92f500)
	/home/user/repos/aerc/widgets/aerc.go:218 +0x3f6
git.sr.ht/~sircmpwn/aerc/lib/ui.(*UI).Tick(0xc0001e4140, 0xc00008a500)
	/home/user/repos/aerc/lib/ui/ui.go:92 +0x190
main.main()
	/home/user/repos/aerc/aerc.go:184 +0x5b7

#42 Implement OAUTH extension 9 months ago

Comment by ~lukehsiao on ~sircmpwn/aerc2

Hi ~benburwell,

On Mon Dec 16, 2019 at 10:03 PM, ~benburwell wrote:

~lukehsiao, check the aerc-imap(5) manpage.

Thanks, that's what I was looking for.

#42 Implement OAUTH extension 9 months ago

Comment by ~lukehsiao on ~sircmpwn/aerc2

I'm struggling a bit to configure gmail with OAUTH. Could anyone point me in the right direction or towards the right documentation?

#333 sorting not working 9 months ago

Comment by ~lukehsiao on ~sircmpwn/aerc2

For what it's worth, I don't think sorting has been implemented quite yet based on this ticket:

https://todo.sr.ht/~sircmpwn/aerc2/17

#332 Configurable :delete folder 9 months ago

feature removed by ~lukehsiao on ~sircmpwn/aerc2

#332 Configurable :delete folder 9 months ago

Comment by ~lukehsiao on ~sircmpwn/aerc2

I've found that Gmail can be configured to behave correctly in response to a message being marked as deleted and expunged from the last visible IMAP folder. The behavior of archiving rather than deleting is the default behavior.

This can be configured by:

Settings > Forwarding and POP/IMAP > IMAP access

Changing Auto-Expunge to off, and then setting "When a message is marked as deleted and expunged from the last visible IMAP folder" to "Move the message to the Trash".

Closing this ticket since it seems clear that aerc is doing the correct thing, and Gmail can be configured to behave correctly.

REPORTED RESOLVED BY_DESIGN