~martijnbraam

The Netherlands

https://brixit.nl/

I do computer stuff

#119 Status filter inside patch list doesn't work 3 months ago

Ticket created by ~martijnbraam on ~sircmpwn/lists.sr.ht

The search bar in the patch list has status:approved as example in the placeholder but the status: filter doesn't actually work.

Example: https://lists.sr.ht/~martijnbraam/pmos-upstream/patches?search=status%3Aproposed

It would also be useful to have be able to negate the status filter so you can view status:!superseded

#118 E-mail without To: header is refused 3 months ago

Ticket created by ~martijnbraam on ~sircmpwn/lists.sr.ht

Currently e-mail sent to lists is refused if it only contains Cc: headers and no To: header. This is an issue because this is the kind of email that's generated by the get_maintainers.pl script in the linux kernel.

#103 Report filter failure 4 months ago

Ticket created by ~martijnbraam on ~sircmpwn/aerc2

Currently it just doesn't show an message body when a filter fails instead of showing the stderr of the filter

#209 Add support for third party artifacts 6 months ago

Ticket created by ~martijnbraam on ~sircmpwn/builds.sr.ht

Since #64 looks like a hard problem. How about adding support for third party artifact storage since the current way to handle artifacts is to send it to somewhere in the buildscript yourself. This is currently used in the build.postmarketos.org system to send the build results to the repository.

To integrate it better with sr.ht it would be nice if it is possible to attach info about the artifacts to the build result using the API. For example:

PATCH /api/jobs/:id HTTP/1.1

{
    "artifacts": [
        {
            "description": "musl-armhf-1.1.21-r0.apk (x86_64)",
            "url": "https://build.postmarketos.org/repository/master/main/x86_64/musl-armhf-1.1.21-r0.apk",
            "size": 367258
        }
    ]
}

Which then can be rendered nicely in the build result page:

#204 Manifests started without execute set 7 months ago

Ticket created by ~martijnbraam on ~sircmpwn/builds.sr.ht

Currently manifests that have execute: false set are executed anyway.

Request:

POST http://builds.sr.ht/api/jobs HTTP/1.1

{"manifest":"image: alpine\/edge\npackages:\n    - python3\n    - coreutils\n    - procps\n    - openssl\n    - wget\n    - sudo\n    - py3-requests\nsources:\n    - 'https:\/\/gitlab.com\/postmarketOS\/pmaports.git#411746babf59587634d513261e2efcf13803ea6f'\ntasks:\n    - { setup-pmbootstrap: 'cd pmaports\/.sr.ht ; .\/install_pmbootstrap.sh' }\n    - { add-key: 'mkdir ~\/.local\/var\/pmbootstrap\/config_abuild ; cd ~\/.local\/var\/pmbootstrap\/config_abuild\/ ; cp ~\/.secrets\/build@postmarketos.org.priv . ; openssl rsa -in build@postmarketos.org.priv -pubout -out build@postmarketos.org.pub ; cp build@postmarketos.org.pub \/tmp\/pmbootstrap\/pmb\/data\/keys\/ ; echo PACKAGER_PRIVKEY=\"\/home\/pmos\/.abuild\/build@postmarketos.org.priv\" > abuild.conf' }\n    - { build: 'cd pmaports\/.sr.ht ; pmbootstrap --details-to-stdout --aports \/home\/build\/pmaports -mp=\"https:\/\/build.postmarketos.org\/repository\/master\/main\" -t 900 build --force --strict --arch=x86_64 0xffff' }\n    - { submit: 'cd pmaports\/.sr.ht ; python3 submit.py --id 0xffff:0.7:1 package-submit ~\/.local\/var\/pmbootstrap\/packages\/x86_64\/0xffff-*-r*.apk' }\nenvironment:\n    COMMIT: 411746babf59587634d513261e2efcf13803ea6f\n    BRANCH: master\nsecrets:\n    - c59eb8f9-cd65-4bde-adad-cb6c2e4ae75a\n    - 27bee529-aeb8-4241-b57b-db7e7b8c581d\ntriggers:\n    - { action: webhook, condition: always, url: 'https:\/\/build.postmarketos.org\/api\/failure-hook' }\n","note":"Building 0xffff[x86_64] from commit [411746babf59587634d513261e2efcf13803ea6f](https:\/\/gitlab.com\/postmarketOS\/pmaports\/commit\/411746babf59587634d513261e2efcf13803ea6f)","execute":false}

Response:

HTTP/1.1 200 OK
Server: nginx
Date: Thu, 14 Mar 2019 23:52:48 GMT
Content-Type: application/json
Content-Length: 13
Connection: close

{"id": 42277}

#163 Trigger for failure not triggering 10 months ago

Ticket created by ~martijnbraam on ~sircmpwn/builds.sr.ht

For example this job: https://builds.sr.ht/~martijnbraam/job/16160

The error is: [#16160] 2018/12/14 13:44:23 Processing post-running triggers... [#16160] 2018/12/14 13:44:23 Skipping trigger, condition unmet

There shouldn't be any condition thats unmet in this case:

triggers:
    - { action: webhook, condition: failure, url: 'https://build.postmarketos.org/api/failure-hook' }

#124 Prevent double submission for comments 11 months ago

Ticket created by ~martijnbraam on ~sircmpwn/todo.sr.ht

You can easily accidentally submit a comment twice if the form submit request loads slowly. This is easily fixable with javascript but not as easy without it.

#62 Add U2F support for 2FA 11 months ago

Comment by ~martijnbraam on ~sircmpwn/meta.sr.ht

the javascript is only needed for users that actually enable u2f for their account if you redirect to the u2f page after login, same thing for the setup page.

#62 Add U2F support for 2FA 11 months ago

Comment by ~martijnbraam on ~sircmpwn/meta.sr.ht

the javascript is only needed for users that actually enable u2f for their account if you redirect to the u2f page after login, same thing for the setup page.

#128 Add environment variable containing the job id 11 months ago

Ticket created by ~martijnbraam on ~sircmpwn/builds.sr.ht

Having a variable like SRHTJOBID in the environment can be useful for tasks that use the API to submit jobs that need to send data back