~mcepl/m2crypto#166: 
Investigate format of expiry time in AuthCookie

Migrated from: https://gitlab.com/m2crypto/m2crypto/-/issues/166
Created by: Matěj Cepl mcepl@cepl.eu
Created at: 2017-03-24T15:45:51.340Z
Milestone: later_break_API

We have there Unix time (in seconds), but shouldn't it be formatted as in Wdy, DD-Mon-YYYY HH:MM:SS GMT?

Status
REPORTED
Submitter
~mcepl
Assigned to
No-one
Submitted
6 months ago
Updated
a month ago
Labels
milestone-0.44

~mcepl 6 months ago

On 2017-03-24T15:46:32.944Z, Matěj Cepl wrote:

@tomato42 just FYI, but I don't want to block %"0.26.1" on it. If it is a problem, then it was a problem for many many releases already.

(Last edited at 2017-03-24T15:47:21.646Z.)

~mcepl 6 months ago

Changed on 2017-09-18T19:47:20.372Z by Matěj Cepl:

created branch 166-investigate-format-of-expiry-time-in-authcookie

~mcepl 6 months ago

Changed on 2017-09-18T20:10:59.704Z by Matěj Cepl:

mentioned in merge request !127

~mcepl 6 months ago

Changed on 2017-09-18T20:25:31.827Z by Matěj Cepl:

changed milestone to later_break_API

~mcepl 6 months ago

On 2017-09-18T20:25:33.864Z, Matěj Cepl wrote:

@tomato42 Postponing this to sometime later, whole AuthCookie needs complete rewrite.

  • classes are old-style
  • they are not subclasses of classes from cookielib
  • they do not support all required methods (e.g., urllib2.HTTPCookieProcessor interface requires self.cookiejar.add_cookie_header(request) and self.cookiejar.extract_cookies(response, request)AuthCookieJar provides neither of them).

And of course, we have to support old API.

(Last edited at 2017-09-18T20:25:53.699Z.)

~mcepl 6 months ago

On 2017-09-18T21:24:19.571Z, Hubert Kario (@mention me if you need reply) wrote:

ack

~mcepl 6 months ago

Changed on 2017-09-20T17:25:06.640Z by Matěj Cepl:

assigned to @mcepl

~mcepl 6 months ago

Changed on 2017-09-24T20:01:51.345Z by Matěj Cepl:

removed assignee

Register here or Log in to comment, or comment via email.