Great, thanks Charlotte! Could you please tell me what version of autoconf you have by running
We need high-quality contributor docs and we don't have any.
The ./bootstrap.sh, ./configure and make steps are pretty unusual for a Python application. These are based on pyconfigure by Brandon Invergo.
I suspect we may be able to add a lot of clarity and remove a significant barrier to contribution by looking at an alternative, but I'm not fully across the background here.
These steps currently:
- update git submodules (bootstrap.sh)
- looks for a python interpreter and virtualenv package
- make a virtualenv
- installs python dependencies into the virtualenv (./bin/python setup.py develop --upgrade) - why does it reinstall things you already have a system site packages?
- runs devtools/update_extlib.sh to install Bower and then bower install jquery etc.
- build translations
- builds texinfo docs (broken and we don't use anyway)
That's all pretty unusual for a Python application, and adds a lot of fairly dense build config/infrastructure.
The translations make sense, and it's nice that the system can find the python interpreter, but beyond that these tools aren't normally used to create virtualenvs and install Python/JS deps. That's a bit unusual.
Noting that the last release of pyconfigure was 0.2.3 in 2016. The pyconfigure website says that the project has been decommissioned.
Installing could be a compelling feature, if we're not installing as a Python package. But maybe a python package would be easier.
I wonder if it's worth chatting to Brandon Invergo about why it was decommissioned?
The only way to get to the "view all a user's media" page is via a hard to spot link at the bottom of the profile page below the first page of media.
This link should be to below the profile text and collections link (if applicable).
It's not so clear what the difference between the profile and the "all media" pages are since they both show media. Maybe the profile should only show the most recent items?
lilmike reported by IRC that:
So I've got a really strange issue. I'm trying to run mediagoblin on arch linux, and running ./bootstrap.sh works fine, but upon running configure I get checking for python3... python3 ./configure: line 1934: syntax error near unexpected token `newline' ./configure: line 1934: ` ''' This has been happening even before the new release, it's just so strange
Ben suspects this is related to the autoconf version as has seen the same in Guix. Specifying autoconf2.69 in Guix fixes the issue.
Fixed in 0db9b5bb by removing the
VIRTUALENV_FLAGS='--system-site-packages'from docs and CI builds.
I've just run:
make distclean ./bootstrap ./configure make
and confirmed that
--system-site-packages. I think we're safe to remove it from our docs and CI builds.
Done! werkzeug.contrib.atom.AtomFeed has been replaced with FeedGenerator and we can now move beyond Werkzeug 1.0.
After fixing the issue of media being marked as failed on celery restart and also the missing celery logging, things aren't looking too bad. Maybe this is not a problem unless we hit another major celery issue.