~mediagoblin/mediagoblin#35: Suggested minor gitignore updates

After a full compilation, there are intermediary files created, which are not in the .gitignore. Namely:

package-lock.json and package.json (generated by npm)
pyvenv.cfg (generated by virtualenv)

Beside them, install-sh is not in the gitignore, while it is automatically created by the autoconf.

This patch improves these in the .gitignore: https://gitlab.com/peter.horvath/mediagoblin/-/commits/gitignore-fix/ Please merge.

Status: REPORTED
Submitter: ~peter_horvath
Assigned to: No-one
Submitted: 2 years ago
Updated: 2 years ago
Labels: No labels applied.

~peter_horvath 2 years ago

~sturm REPORTED IMPLEMENTED 2 years ago

Thanks ~peter_horvath. I've merged this change. The challenge with package-lock.json and package.json is that they're a symptom of us needing to move to npm install and possibly adding a JS build step as opposed to using the legacy Bower tool.

~sturm IMPLEMENTED REPORTED 2 years ago

Hmm, removing install-sh seems to have broken our SourceHut CI builds, so I've rolled back that change. I don't know enough about install-sh to see what the issue is. It appears to be regenerated locally for me when ./bootstrap.sh runs, but not in CI.

https://builds.sr.ht/~mediagoblin/job/952036 (Debian 11) https://builds.sr.ht/~mediagoblin/job/952037 (Ubuntu 20.04)