~mediagoblin/mediagoblin#35: 
Suggested minor gitignore updates

After a full compilation, there are intermediary files created, which are not in the .gitignore. Namely:

  1. package-lock.json and package.json (generated by npm)
  2. pyvenv.cfg (generated by virtualenv)

Beside them, install-sh is not in the gitignore, while it is automatically created by the autoconf.

This patch improves these in the .gitignore: https://gitlab.com/peter.horvath/mediagoblin/-/commits/gitignore-fix/ Please merge.

Status
REPORTED
Submitter
~peter_horvath
Assigned to
No-one
Submitted
1 year, 4 months ago
Updated
1 year, 1 month ago
Labels
No labels applied.

~peter_horvath 1 year, 4 months ago

~sturm REPORTED IMPLEMENTED 1 year, 1 month ago

Thanks ~peter_horvath. I've merged this change. The challenge with package-lock.json and package.json is that they're a symptom of us needing to move to npm install and possibly adding a JS build step as opposed to using the legacy Bower tool.

~sturm IMPLEMENTED REPORTED 1 year, 1 month ago

Hmm, removing install-sh seems to have broken our SourceHut CI builds, so I've rolled back that change. I don't know enough about install-sh to see what the issue is. It appears to be regenerated locally for me when ./bootstrap.sh runs, but not in CI.

https://builds.sr.ht/~mediagoblin/job/952036 (Debian 11) https://builds.sr.ht/~mediagoblin/job/952037 (Ubuntu 20.04)

Register here or Log in to comment, or comment via email.