~mil/mepo-tickets#37: 
Download mode broken

When I run mepo -d, I get the following output:

Boot Mepo in mode: enum:18:15.Download
Downloading based on BBox request: thread 5183 panic: reached unreachable code
Aborted

I think the issue was introduced in 370c7197ff58243809fe8c3e0511d723b68ca1a2:

commit 370c7197ff58243809fe8c3e0511d723b68ca1a2
Author: Miles Alan <m@milesalan.com>
Date:   Fri Mar 4 19:14:02 2022 -0500

    Disable stderr debugging by default; add -e hotkey to set stderr_debug to 1
    
    Stderr debugging slows down rendering generally, better default to not log

diff --git a/src/main.zig b/src/main.zig
index f984d3e..25b1537 100644
--- a/src/main.zig
+++ b/src/main.zig
@@ -31,7 +32,9 @@ pub fn main() !void {
         } else if (std.mem.startsWith(u8, arg, "-d")) {
             // -d: Downloader mode (non-video), runs cfg
             mode = .Download;
-            download_request = arg[2..];
+        } else if (std.mem.startsWith(u8, arg, "-e")) {
+            // -e: Enable stderr debugging
+            stderr_on = true;
         } else if (std.mem.startsWith(u8, arg, "-sw")) {
             // -sw: Use software renderer instead of default HW renderer
             use_sw_renderer = true;

The line setting the download_request variable got deleted, but it's still passed to cache_dlbbox.

Status
RESOLVED FIXED
Submitter
~jakewaksbaum
Assigned to
No-one
Submitted
15 days ago
Updated
12 days ago
Labels
bug

~mil REPORTED FIXED 12 days ago

Thanks for looking into & flagging this (!) it was indeed broken based on the commit you mentioned.

I've corrected this issue on tip & also tagged 0.4.2 to correct this as well as this is a blaring issue.

Register here or Log in to comment, or comment via email.