~mil/sxmo-tickets#117: 
User logged out when menu opened from top down swipe in 1.1.11

Steps to replicate:-

  1. Swipe top down to open the menu
  2. Select Dailer option
  3. Select Close Menu
  4. User mo is logged out automatically and login screen is shown.

When any option selected at the center of the screen, it is observed that user is logged out. Observed only in case when menu is opened using swipe option. The same issue is not observed when up button is used to open the menu.

Selecting the dwm to open the menu which was present in previous release was a better option for me and this user logout is not observed.

Status
RESOLVED FIXED
Submitter
~arjunaithal
Assigned to
No-one
Submitted
1 year, 8 months ago
Updated
1 year, 8 months ago
Labels
bug

~anjan 1 year, 8 months ago

I can reproduce this on the latest nightly sxmo-utils. Thanks for posting.

~anjan 1 year, 8 months ago

I investigated this today. So the issue is here:

https://git.sr.ht/~mil/sxmo-utils/tree/master/scripts/modem/sxmo_modemdial.sh#L30

Basically, this line kills the subprocess ie. the dialmenu() function. As such, even if the user has selected "Close Menu", the script still runs sxmo_modemcall.sh pickup "$CREATEDCALLID" at the bottom of the script (line 47). I tried exporting the PID for the top level script by running export TOPPID=$$ when the script starts and killing "$TOPPID" but that did not fix it. I dont really know how to fix this but if someone has a recommendation please send a patch!

~anjan referenced this from #110 1 year, 8 months ago

~anjan REPORTED FIXED 1 year, 8 months ago

Ignore everything I said above. I think this issue where a script failing causes dwm to come crashing down is bad but that is something I will investigate later. Currently, this issue is fixed for this script by this commit:

https://git.sr.ht/~mil/sxmo-utils/commit/8b873860066e43eb5ceb10be4599bca88de6d0ac

This fix will be in the 1.2.0 release. Thank you for reporting ~arjunaithal!

~anjan FIXED REPORTED 1 year, 8 months ago

~anjan 1 year, 8 months ago*

I spoke too soon. That patch didnt fix it. It seems that this bug only appears after a fresh boot. After a while, I don't experience this bug.

~proycon REPORTED FIXED 1 year, 8 months ago

This is fixed now by his patch: https://lists.sr.ht/~mil/sxmo-devel/patches/15411

Register here or Log in to comment, or comment via email.