~mil/sxmo-tickets#169: 
sxmo-utils: replace "sxmo-pinephone" service with something more generic?

I'm currently reviewing postmarketos-ui-sxmo and noticed, that sxmo-utils provides a sxmo-pinephone service:

https://git.sr.ht/~mil/sxmo-utils/tree/master/item/configs/openrc/sxmo-pinephone

In order to make this less pinephone specific, I suggest the following refactoring:

  • instead of directly running chmod a+rw in the openrc service, put it in a dedicated script, so we can add some more logic to it
  • if pine64,pinephone is in /sys/firmware/devicetree/base/compatible (or pinetab? not sure if supported by sxmo), then run the pinephone specific commands you already have
  • (other devices could be added later)
  • for better readability and better diffs, put one path in one line
  • rename the service to something more generic, maybe even a more descriptive name. maybe sxmo-chmod?
Status
RESOLVED FIXED
Submitter
~ollieparanoid
Assigned to
Submitted
5 months ago
Updated
4 months ago
Labels
infra ready

~proycon 5 months ago

Thanks for the feedback! The sxmo-pinephone service was indeed introduced in 1.3.0 . I agree with your points, having a more generic service would be better and easier for the future. I'll rework this a bit for next release.

~proycon referenced this from #205 4 months ago

~ollieparanoid referenced this from #215 4 months ago

~proycon REPORTED FIXED 4 months ago

Register here or Log in to comment, or comment via email.