~mil/sxmo-tickets#49: 
sxmo-utils: Can't exit from Youtube scripts search results without choosing a video

There should be an option at the top of the menu to allow going back and/or closing the menu (at top because there could be a bunch of entries).

Status
RESOLVED FIXED
Submitter
~jpsamaroo
Assigned to
No-one
Submitted
4 years ago
Updated
4 years ago
Labels
bug

~ozzeruk 4 years ago

I was also going to report this. All menus need a 'back' option. Without one it isn't clear how you're supposed to close the menu.

~fedon 4 years ago

May be for menu we can use R-L gesture. That would be intuitive. For now they are disabled, right?

~fedon 4 years ago

I have checked details:

  • gestures are active with menu;
  • add return on top is easy (I would assign it to myself, but I have no permission)
  • in general there is no way back as state of parent menu is to exit when done in most cases;
  • that is why most menus have a hook to System menu. Thus, gesture way would be over-complicated.

~mil 4 years ago

Agreed this could be more consistent across menus - alot of stuff happens in sxmo_appmenu.sh where the "Close Menu" is automatically added - but there are other scripts that don't use this. In most places I've added the "Close Menu" entry but I agree we should add this in all places possible.

An alternative; which actually might be easier at this point (and way more consistent) would be to just write a dmenu patch which adds a close button (enabled/disabled via CLI flag) and then do something like grep . or check for exitcode 1 from dmenu if you exit via an [X] button or something. Would also need to change the next/prev logic in dmenu to hit this so the pinephone buttons could access the [X] button as well.

~mil REPORTED FIXED 4 years ago

Should be fixed in sxmo-utils 1.1.7 for the youtube script. I do want to eventually implement a cancel globally for dmenu but that's a larger change and will handle with separate ticket

Register here or Log in to comment, or comment via email.