~mil/sxmo-tickets#534: 
KEYBOARD_ARGS not compatible with toggle WM

wvkbd and svkbd don't have uniformity in their arguments, noticably:

  • -H: in wvkbd this is in pixels, in svkbd it's in percents?
  • -O: in wvkbd it's an output mode, it disables overlays

Unsure what is the best way to proceed.

Status
REPORTED
Submitter
~earboxer
Assigned to
No-one
Submitted
2 months ago
Updated
2 months ago
Labels
No labels applied.

~phartman 2 months ago

sxmo mantains wvkbd, so I'd say we change svkbd to make it act like svkbd.

On Sun, Sep 18, 2022 at 03:55:11AM +0000, ~earboxer wrote:

wvkbd and svkbd don't have uniformity in their arguments, noticably:

  • -H: in wvkbd this is in pixels, in svkbd it's in percents?
  • -O: in wvkbd it's an output mode, it disables overlays

Unsure what is the best way to proceed.

-- View on the web: https://todo.sr.ht/~mil/sxmo-tickets/534

-- sic dicit magister P https://phartman.sites.luc.edu/ GPG keyID 0xE0DBD3D6 (CAE6 3A6F 755F 7BC3 36CA 330D B3E6 39C6 E0DB D3D6)

~phartman referenced this from #534 2 months ago

~earboxer 2 months ago

For the time being, I wrapped my export KEYBOARD_ARGS in a if test $SXMO_WM = 'sway'

Percentage for the height makes the most sense (it's independent of scaling factors), though I'm not sure how it works (just that setting it to '140' resulted in a small keyboard).

(invalid flag values should just be ignored)

Renaming wvkbd's -O option is probably the 'right thing' (it's the newer of the two, and I think only 2 people actually use it ( ~aren and I), though I could argue that svkbd's flag is less useful and fewer things depend on it.

We should update the codebases to parse (and ignore) eachother's flags so we don't define one on top of the other again.

Register here or Log in to comment, or comment via email.