~mil/sxmo-tickets#590: 
Long $KEYBOARD won't toggle closed

When setting KEYBOARD="wvkbd-custom" in ~/.config/sxmo/profile, the call to pkill in close() in /usr/bin/sxmo_keyboard.sh fails due to the resolved path exceeding a 15 character limit for the argument to pkill. Since double quotes are shown elsewhere, e.g. in the tips and tricks wiki page section on $KEYBOARD_ARGS, this is an easy mistake and the reason for the error is non-obvious to a naive user.

pkill with the -f flag yields the correct behaviour, as does unquoted KEYBOARD=wvkbd-custom (not resolved path: <15 characters). Perhaps a warning comment in ~/.config/sxmo/profile would alert a user to the issue.

Status
REPORTED
Submitter
~forestcreature
Assigned to
No-one
Submitted
6 months ago
Updated
6 months ago
Labels
No labels applied.

~aren 6 months ago*

We uesd pkill -f for a while, I don't remember there being a reason to remove it. Based on git blame it was just a careless refactoring so I resent the patch https://lists.sr.ht/~mil/sxmo-devel/%3C20231003182204.1861761-1-aren%40peacevolution.org%3E

Register here or Log in to comment, or comment via email.