Hey SXMO folks,
as the v24.06 release of pmOS is around the corner, I'm finally finishing up things from this discussion in IRC from January:
ollieparanoid: I have a question for SXMO maintainers: how would you feel about having the default wallpaper for Sxmo changed in postmarketOS? ollieparanoid: a great wallpaper artist dikasp showed up and made some amazing ones here: https://gitlab.com/postmarketOS/artwork/-/merge_requests/25 ollieparanoid: so we could actually have one per postmarketOS release. they made it for GNOME initially, but we are already considering using it for other UIs too like Plasma Mobile, and possibly Sxmo. anjan: I will ask about those wallpapers. They really do look beautiful :D staceee: seems great! we would have to refactor a bit how we select the picture, but should be easy for us
The wallpaper is already set for GNOME, Phosh and (MR open) Plasma Mobile.
So how would I set it for Sxmo? I've browsed a bit through the source, and I guess an elegant way could be writing a /etc/profile.d/sxmo_set_pmos_wallpaper.sh, which contains:
export SXMO_BG_IMG="/usr/share/wallpapers/postmarketos.jpg"
However this doesn't work currently. I guess the script that gets installed to ~/.config/sxmo/profile would need to be changed to not set SXMO_BG_IMG, if it was already set by an environment variable before.
Does it make sense to do it like this, or do you have a better suggestion?
If you have time, could you adjust the mentioned profile script so this works? We could then backport this patch to sxmo-utils in alpine edge and 3.20, so it ends up in pmOS v24.06.
More details on packaging: /etc/profile.d/sxmo_set_pmos_wallpaper.sh will live in a new postmarketos-artwork-wallpapers-sxmo subpackage, which has install_if for sxmo and postmarketos-artwork-wallpapers. Then postmarketos-artwork-wallpapers will be added to _pmb_recommends of Sxmo UIs. That way people could just uninstall the package if they prefer to have the default wallpaper.
Thank you very much!
Ah I just realized, there already was a patch: https://lists.sr.ht/~mil/sxmo-devel/patches/49309
Thanks, Willow!
I guess I'll need to set $SXMO_OS for this... will look more into this soon.
Do you have a link for that script?
to me this would need modifying to source that script to set the env variable:
configs/appcfg/profile_template:export SXMO_BG_IMG="$(sxmo_hook_wallpaper.sh)"
It looks like that change profile_template is already included. SXMO_OS should be set to the value of ID in /etc/os-release, so it might just work? I'm not sure where your backgrounds package puts things, and what pmos / alpine put in os-release
Hey o/
I've just given a try to it, and confirm it works here.
Adding postmarketos-artwork-wallpapers in world, is enough for sxmo_hook_wallpaper.sh to output /usr/share/wallpapers/postmarketos.jpg. It will be used before the sxmo-utils provided one.
I think we "just" have to tag a release, and add the dependency in the pmaports sxmo recipes. As usual, we are not in time for the pmos releases :')
Ah indeed sxmo_hook_wallpaper.sh isn't in Sxmo 1.5.2 yet. But this is a really elegant solution, looking forward to using this :)
I think we "just" have to tag a release, and add the dependency in the pmaports sxmo recipes. As usual, we are not in time for the pmos releases :')
Regarding v24.06 release timeline: today was the feature freeze, and tomorrow the testing week starts. After that comes the release week: https://wiki.postmarketos.org/wiki/Creating_a_release_branch#Timeline
It would of course be great to have the next Sxmo version in v24.06, and we could make an exception for it from the feature freeze, if you think it is ready. Is that the case, and could you tag a release today or early in the coming week? (The earlier it is tagged, the more time is for testing.)
Alternatively I would propose to backport the wallpaper patch to 1.5.2.
What do you think?
I've tagged right now, and the aports MR is already prepared.
Nothing that critical changed since 1.15. So I'll stay alert if something important need to be patched.
Perfect, thank you very much!
I've verified that it works as expected now on v24.06 :) This can be closed, thanks!