~min

Trackers

~min/fb2ms

Last active 2 years ago

#113 parentheses are not escaped for shell 3 months ago

Ticket created by ~min on ~lattis/muon

Ninja will fail if the command for custom_target contains arguments with parentheses. Found such target in the older version of glib2.

Quick fix (dunno about Windows):

--- src/platform/posix/path.c.old       Sat Feb 10 18:35:59 2024
+++ src/platform/posix/path.c   Sat Feb 10 18:36:17 2024
@@ -31,7 +31,7 @@ path_to_posix(char *path)
 void
 shell_escape(struct workspace *wk, struct sbuf *sb, const char *str)
 {
-       const char *need_escaping = "\"'$ \\><&#\n";
+       const char *need_escaping = "\"'$ \\><&#()\n";
        const char *s;
        bool do_esc = false;