#57 compilation error [-Wimplicit-function-declaration] 3 months ago

Comment by ~ofiala on ~sircmpwn/gmni

OpenSSL is not supported by my distribution ¯\_(ツ)_/¯

#57 compilation error [-Wimplicit-function-declaration] 3 months ago

Ticket created by ~ofiala on ~sircmpwn/gmni

Compilation error with both gcc and clang on master (f5d540bc5):

CC	src/tofu.o
src/tofu.c:40:7: error: implicit declaration of function 'ASN1_TIME_diff' is invalid in C99 [-Werror,-Wimplicit-function-declaration]
        if (!ASN1_TIME_diff(&day, &sec, NULL, notBefore)) {
src/tofu.c:125:3: error: implicit declaration of function 'ASN1_TIME_to_tm' is invalid in C99 [-Werror,-Wimplicit-function-declaration]
                ASN1_TIME_to_tm(notAfter, &expires_tm);
src/tofu.c:125:3: note: did you mean 'ASN1_TIME_set_tm'?
/usr/include/openssl/asn1.h:779:12: note: 'ASN1_TIME_set_tm' declared here
ASN1_TIME *ASN1_TIME_set_tm(ASN1_TIME *s, struct tm *tm);
2 errors generated.
make: *** [Makefile:42: src/tofu.o] Error 1

Since the error concerns OpenSSL, I should perhaps mention that the system uses LibreSSL (v3.1.5) instead of OpenSSL.

#15 Please disable CSRF tokens 4 months ago

Comment by ~ofiala on ~danskeren/ask.moe

Awesome, thank you :)

#15 Please disable CSRF tokens 4 months ago

Comment by ~ofiala on ~danskeren/ask.moe

The second point was phrased rather poorly. Let's try again:

The reason why ask.moe does not work in Lynx for me is the fact that I have disabled cookies. As far as I am aware, it is not possible to whitelist cookies in Lynx. You can either blacklist them (cookies enabled globally and answering "never" to the cookie prompt) or reject all by disabling cookies globally. If you have ever used Lynx on the modern web, you know that answering the cookies prompts gets very annoying very quickly as the vast majority of the web uses a lot of cookies. Thus, to use ask.moe in Lynx, one would have to fight all those prompts, which is just not worth it.

Therefore, ask.moe is currently unusable in sane Lynx configurations.

#15 Please disable CSRF tokens 4 months ago

Ticket created by ~ofiala on ~danskeren/ask.moe

I am not sure what is the reason behind having these in the first place, but one of the features of a private search engine should definitely be the ability to search without cookies. This will have several benefits for users, such as:

  1. by disabling JS and cookies, they can be sure ask.moe doesn't track them without having to read through its source code
  2. they will be able to use ask.moe in HTML-only browsers such as Lynx, which is something I am interested in myself

There might be other benefits as well.

#16 agreety: verbose errors, bug makes me unable to login under certain conditions 5 months ago

Ticket created by ~ofiala on ~kennylevinsen/greetd

When I enter invalid password, agreety should output "Login incorrect" like login(1). It outputs this instead:

error: authentication error: pam_authenticate: SERVICE_ERR
Login incorrect

<hostname> login: client loop failed: i/o error: Broken pipe (os error 32)

If I press Ctrl + C at this point, the login prompt gets printed again in full (as exptected), however when I press any of the directional buttons (left, right, up down arrows), I am able to move the cursor freely around the screen. After that, I can no longer login and have to restart the machine.

Steps to reproduce: the description above should be sufficient