Germany
https://fosstodon.org/@outsidecontext
Software developer and free software / open source enthusiast. Mostly doing MusicBrainz related projects.
Comment by ~phw on ~phw/go-musicbrainzws2
REPORTED
RESOLVED IMPLEMENTEDComment by ~phw on ~phw/go-musicbrainzws2
REPORTED
RESOLVED IMPLEMENTED~phw assigned ~phw to #5 on ~phw/go-musicbrainzws2
enhancement added by ~phw on ~phw/go-musicbrainzws2
Ticket created by ~phw on ~phw/go-musicbrainzws2
Support querying all genres using the
/genre/all
endpoint, e.g. https://musicbrainz.org/ws/2/genre/all?fmt=jsonNote that this is a paginated endpoint. It is very much a special case of browse.
~phw assigned ~phw to #4 on ~phw/go-musicbrainzws2
Comment by ~phw on ~phw/go-musicbrainzws2
I decided to break the API and introduce a single
Client.BrowseURLs
and removing the oldClient.LookupURLByResource
.The new method allows querying multiple URLs by specifying multiple target URLs in
URLFilter.Resources
. The fact that the response differs if only a single URL is requested is abstracted away.Client.BrowseURLs
always returns a response with a list of URLs.This gives a clean API that is consistent with other entities and URLs now support Lookup, Browse and Search in the same way as other entities.
See commit 9b7da2e4301532f67f949b8dc6d7d1d72e61e046.
REPORTED
RESOLVED IMPLEMENTEDComment by ~phw on ~phw/go-musicbrainzws2
Is this actually necessary? It is not so much different to
Client.BrowseGenreCollection
. Compare these two:
- Browse genres: https://musicbrainz.org/ws/2/genre?collection=123ac49b-3456-4a01-9df8-9ab0c67ae9a3&fmt=json
- Browse collection with genres: https://musicbrainz.org/ws/2/collection/123ac49b-3456-4a01-9df8-9ab0c67ae9a3/genres?fmt=json
The browse request would be much more useful if it would support more linked entities, but for now
collection
seems to be the only one.
enhancement added by ~phw on ~phw/go-musicbrainzws2