Hi J.P.,

thanks for the report. I cannot see anything obviously wrong in the long CI trace.

We test Compat in CI on Github including the function string-search, see https://github.com/emacs-compat/compat/actions/runs/3863875684/jobs/6586332377. It is green on all versions.

There are two things which come to my mind:

• Are you sure that Compat is loaded properly in your test suite, such that no problem is shadowed by the noerror require? You could use (require 'compat) and print the features variable afterwards to check which features are loaded. On Emacs 27 the features compat, compat-29 and compat-28 should be loaded.

• You ensure that Compat is compiled with the same Emacs version as the one you are run the tests with? It should be possible to load Compat on newer Emacs versions, but not on older Emacsen since then functions will be missing.

Do you have a simple recipe which allows me to reproduce and debug your issue locally?

Daniel

On 1/10/23 15:11, ~jpneverwas wrote:

Hi Compat people,

This started happening a few days ago with the release of 29.1.0.1:

https://gitlab.com/emacs-erc/edge/-/jobs/3562370600/raw

And it's still going on under 29.1.1.0:

https://gitlab.com/emacs-erc/edge/-/jobs/3580021763/raw

If something is required on my end, please let me know.

Thanks, J.P.

Hi J.P.,

I just gave this a check locally. I cloned the edge repository. Your test suite is not properly loading compat. It seems there is a problem with how you install Compat and setup your load path. I applied the attached patch and then executed make shim; make test locally with Emacs 27. Everything works as expected.

Daniel

"~minad" outgoing@sr.ht writes:

Hi J.P.,

I just gave this a check locally. I cloned the edge repository.

Ugh. Sorry you had to go through that. As you've rightly surmised, this whole thing boils down to rank stupidity/sloppiness on my part.

Your test suite is not properly loading compat. It seems there is a problem with how you install Compat and setup your load path.

You're right, of course. We definitely ought to just install the package properly.

I applied the attached patch and then executed make shim; make test locally with Emacs 27. Everything works as expected.

Daniel

Apologies again for time waste. This ticket can obviously be closed.

Thanks, no apology needed. It didn't take me much time since I had already guessed the cause of the issue correctly. In any case if you discover issues with Compat let us know asap. Compat tries hard to stay out of the way (no advices, no accidentally overridden definitions, compiles to minimal definitions). Nevertheless Compat can lead to issues, which are hard to debug, since it is not restricted to a package namespace. Also Compat is already rolled out widely via Magit from MELPA and via my Consult package from ELPA/MELPA. The earlier we hear about potential problems, the better, even if the problem is only a false positive as in this case.

Daniel