~midgard added feature 3 years ago

~reedwade 3 years ago

You mean older posts than we those we have in history ?

~midgard 3 years ago

Yep

~reedwade 3 years ago

Adding line on top of history is a pain in the ass with Weechat and this feature would require a lot of work from wee-matter. Maybe dropping the message completely was a bad solution but it seems the simplest and the more maintainable.

But maybe we could just pop the message with a "not available parent" msg

~midgard 3 years ago

Yep, that would be a good start. I've been playing with replies a bit, making them easier to follow, in the commit "Improve quote layout" on my master. I had already written parent_message = "<older message {}>".format(post.parent_id) there, which is what you're proposing now too. I could extract that and submit it as a patch, or if you're happy with the entirety of the rework I could just submit it as-is.

I wasn't thinking of adding the parent post in the WeeChat buffer, just fetching it and showing its text as is done now for replies. But this is quite hard with the buffer being the only log of the messages that we keep.

~reedwade 3 years ago

I wasn't thinking of adding the parent post in the WeeChat buffer, just fetching it and showing its text as is done now for replies. But this is quite hard with the buffer being the only log of the messages that we keep.

Yeah, as you can see, adding more feature rapidly create lot of complexity.

Yep, that would be a good start. I've been playing with replies a bit, making them easier to follow, in the commit "Improve quote layout" on my master. I had already written parent_message = "<older message {}>".format(post.parent_id) there, which is what you're proposing now too. I could extract that and submit it as a patch, or if you're happy with the entirety of the rework I could just submit it as-is.

In the current state, the reply-to implementation seems enough to understand and follow the discussion to me. It seems similar to the Mattermost webui (which is not perfect if you skip the right sub-discussion panel)

Anyway, It feels nice to see someone playing with the plugin and making it his own. My repository is always open to patches but I warn you that I will be restrictive on this kind of little improvment that are in detriment of lot of complexity. But patches will be searcheable in the list and could be used by anyone which is always nice.