~rjarry/aerc#215: 
regression since bumping go-maildir

aerc now errors when trying to open a folder with two colons.

See discussion on the ML: https://lists.sr.ht/~rjarry/aerc-devel/%3CCY9A00KH5C1Z.26PY7P1UCTWZP%40ferdinandy.com%3E

Status
REPORTED
Submitter
~ferdinandyb
Assigned to
No-one
Submitted
a month ago
Updated
28 days ago
Labels
bug

~ferdinandyb 30 days ago

I looked into the error. What happens is that go-maildir stops parsing when it runs into an error, but returns whatever it already had: https://git.sr.ht/~rjarry/aerc/tree/40c25caafd583d4ee6ab3f5b318306e534abe480/item/worker/maildir/container.go?view-source#L71

So unfortunately, not only the bad files are dropped, but other things as well. Ideally, go-maildir should probably return all keys that it can and then we should display all of those and an error.

~ferdinandyb 30 days ago

On the other hand looking at the maildir code I can't see why it would not return all valid files?

https://github.com/emersion/go-maildir/blob/67011827de5fd93ea533d83f30a164569b2bd190/maildir.go#L204

~ferdinandyb 30 days ago

Note: the error itself (not parsing 1686325684.2046813_1.mashenka,U=103:2:2,RS correctly persists in 0.4.1. I still need to test whether go-maildir actually returns all the valid files or just up until it encounters the error.

~rjarry 30 days ago

Bence Ferdinandy referenced this ticket in commit 1a129a2.

~ferdinandyb 28 days ago

After some discussion the double colon is definitely a malformed maildir file. On the other hand, currently maildir-go does seem to stop once it finds a bad messages. Upgrade is in progress here.

Register here or Log in to comment, or comment via email.