~rjarry/aerc#38: 
aerc crashes on piping image (macOS)

I don't know how to open image attachments. So when I selected the image part on the multipart selection menu at the bottom, it showed the options to :save or to :pipe. So I tried :pipe -p open, as I wanted open to handle the image.

It crashed. Running on Mac OS X Big Sur 11.6.3, installed from Homebrew.

goroutine 1 [running]:
runtime/debug.Stack()
	/usr/local/Cellar/go/1.18/libexec/src/runtime/debug/stack.go:24 +0x65
runtime/debug.PrintStack()
	/usr/local/Cellar/go/1.18/libexec/src/runtime/debug/stack.go:16 +0x19
main.PanicTermFix(0x0)
	/private/tmp/aerc-20220321-78933-4tfl9p/aerc-0.9.0/aerc.go:236 +0x45
panic({0x452c040, 0x4a53b60})
	/usr/local/Cellar/go/1.18/libexec/src/runtime/panic.go:844 +0x258
github.com/creack/pty.StartWithAttrs(0x0, 0xc0000b7830, 0xc000238000)
	/Users/brew/Library/Caches/Homebrew/go_mod_cache/pkg/mod/github.com/creack/pty@v1.1.17/run.go:58 +0x152
git.sr.ht/~rjarry/aerc/widgets.(*Terminal).Draw(0xc00067c240, 0xc0003122a0)
	/private/tmp/aerc-20220321-78933-4tfl9p/aerc-0.9.0/widgets/terminal.go:245 +0x105
git.sr.ht/~rjarry/aerc/lib/ui.(*TabContent).Draw(0xc00028e630?, 0x0?)
	/private/tmp/aerc-20220321-78933-4tfl9p/aerc-0.9.0/lib/ui/tab.go:394 +0x12e
git.sr.ht/~rjarry/aerc/lib/ui.(*Grid).Draw(0xc0000c24d0, 0xc00028e630)
	/private/tmp/aerc-20220321-78933-4tfl9p/aerc-0.9.0/lib/ui/grid.go:144 +0x2ff
git.sr.ht/~rjarry/aerc/widgets.(*Aerc).Draw(0xc0000c2580, 0xc00028e630)
	/private/tmp/aerc-20220321-78933-4tfl9p/aerc-0.9.0/widgets/aerc.go:177 +0x2e
git.sr.ht/~rjarry/aerc/lib/ui.(*UI).Tick(0xc000284050)
	/private/tmp/aerc-20220321-78933-4tfl9p/aerc-0.9.0/lib/ui/ui.go:113 +0x1f7
main.main()
	/private/tmp/aerc-20220321-78933-4tfl9p/aerc-0.9.0/aerc.go:221 +0xa4a
aerc crashed: runtime error: invalid memory address or nil pointer dereference
Status
REPORTED
Submitter
~andrescutieri
Assigned to
No-one
Submitted
a month ago
Updated
a month ago
Labels
No labels applied.

~rjarry a month ago

Hi,

There is actually an (unbound by default) :open command that calls the system handler.

https://git.sr.ht/~rjarry/aerc/tree/master/item/doc/aerc.1.scd#L336

There are a few pending patches to make this more visible:

https://lists.sr.ht/~rjarry/aerc-devel/patches/31027 https://lists.sr.ht/~rjarry/aerc-devel/patches/31028

I could not reproduce the issue with linux however. Could you try with the latest dev version?

Register here or Log in to comment, or comment via email.