~rjarry/aerc#8: 
bindings: <C-h> = :prev-tab<Enter> broken in 0.6.0

Thank you for reactivating the project!

After I updated to 0.6.0, both the :prev-tab command and my next-tab bind work as they had in 0.5.2, but the prev-tab binding has no effect. I looked at the recent binding commits and nothing jumped out at me as the probable cause.

Status
RESOLVED FIXED
Submitter
~dmfay
Assigned to
No-one
Submitted
5 months ago
Updated
4 months ago
Labels
No labels applied.

~rjarry 5 months ago

I wonder if that is related to the upgrade of tcell. Depending on your terminal, ^h may send the backspace code.

~muellerj 5 months ago

I have the same issue. My terminal is alacritty, fish_key_reader reports the following:

$ fish_key_reader
Press a key:
              hex:    8  char: \cH  (or \b)
bind -k backspace 'do something'
bind \b 'do something'

~muellerj 4 months ago*

Downgrading tcell from v2.4.0 to v2.0.0 does not seem to fix the issue. Any ideas what else could cause this regression?

~rjarry 4 months ago

Do you reproduce the issue with another terminal emulator? If not, maybe this is related to alacritty terminfo?

~muellerj 4 months ago

I can reproduce the error in Konsole and kitty as well.

~richardhuxton 4 months ago*

I added this line just above line 243 in widgets/aerc.go

aerc.logger.Printf("bindings.GetBinding(%v)", aerc.pendingKeys)

The codes I got for ctrl+h were {0 8 8} (no modifier, key=8, rune=8) which does indeed look like a backspace.

I noticed config/bindings.go had a list of keys and then tried binding <bs> - which seemed to work for me. If that is the same for the other commenters then we have a simple work-around at least.

Could the behaviour have changed back when the modifier was added to the KeyStroke struct? The tcell change just being a coincidence?

~shalzz 4 months ago*

Yes, indeed binding <bs> = :prev-tab<Enter> allows moving back to a prev tab with <C-h>

~muellerj 4 months ago

Same here

~rjarry REPORTED FIXED 4 months ago

Robin Jarry referenced this ticket in commit b963265.

~rjarry 4 months ago

Robin Jarry referenced this ticket in commit b963265.

~rjarry 4 months ago

Robin Jarry referenced this ticket in commit b963265.

~rjarry 4 months ago

Robin Jarry referenced this ticket in commit b963265.

Register here or Log in to comment, or comment via email.