~rockorager 3 months ago

Good catch...I see the issue already - when the terminal widget gets an OSC 11 query it queries the host terminal in a goroutine, and then responds. This will definitely get the ordering wrong.

This is problematic because I batch my queries on startup, and use the DA1 response as a sentinel between query response and user input. If I get DA1 before OSC 11, then I end up interpreting OSC 11 as user input.

I can (and will likely) modify my input loop to accomodate for this, but it's probably best to fix it here so that we can eventually rid the ecosystem of such kludges.

That sounds like it might cause issues elsewhere...I haven't seen any other terminals which would get this ordering wrong (I do queries in the same way). I'd caution against patching over this vaxis bug in your code...unless you have a nice way to do it which won't break other things :)

Thanks for the detailed report, I'll have this fixed shortly. Also...chawan is amazing, thanks for your work on it!

~rockorager REPORTED FIXED 3 months ago

Tim Culverhouse referenced this ticket in commit e2b805b.

~bptato 3 months ago

Oh, I didn't expect such a quick resolution. Thank you!

That sounds like it might cause issues elsewhere...I haven't seen any other terminals which would get this ordering wrong (I do queries in the same way).

I have, it's GNU screen, but out of laziness I just patched over it with a TERM check. I should at least post a bug report over there too...

Also...chawan is amazing, thanks for your work on it!

thanks :)

~bptato referenced this from ~bptato/chawan#33 3 months ago