~scoopta/taiga#1: 
Support more codecs

#Current behavior

If any other codec (via the -f option) than apng is used, such as gif, taiga crashes with the following message :

[gif @ 0x56186259d800] Specified pixel format rgba is invalid or not supported

Also, trying to set an unsupported codec (like a text codec) leads to a segmentation fault :

$ taiga -f xsub
[NULL @ 0x5589e3b94540] Requested output format 'xsub' is not a suitable output format

Segmentation fault (core dumped)

#Correct behavior

taiga should output an error message if an unsupported codec is used instead of crashing, and support for more codecs should be added (like gif, mjpeg, ...).

I'm particularly interested in the gif format since it leads to much smaller files than apng.

#Fix

As I understand, the format given to main() is just sent to taiga_cap() which uses it to get the encoder with avcodec_find_encoder_by_name() without processing. The format should be checked in main() against a list of supported format.

To support gif encoding, it seems we need to give a RGB pixel format to the encoder instead of RGBA when the gif format is selected, but I could be wrong here.

Status
REPORTED
Submitter
~g33kex
Assigned to
Submitted
1 year, 6 months ago
Updated
1 year, 6 months ago
Labels
No labels applied.

~scoopta 1 year, 6 months ago

Yeah, taiga was kinda put together and then forgotten about. I'm the only one I know of that uses it. I'll definitely work on fixing this though

Register here or Log in to comment, or comment via email.