~sersorrel


#417 Default quoted_reply timestamp handling is broken a month ago

Comment by ~sersorrel on ~sircmpwn/aerc2

That appears to fix the problem, yep!

#417 Default quoted_reply timestamp handling is broken a month ago

Ticket created by ~sersorrel on ~sircmpwn/aerc2

I think I understand what the default quoted_reply template /tries/ to do to the timestamp (display the timestamp of the message using the local timezone), and it's a fair goal, but it doesn't work at all.

I've just received an email with a Date of Wed, 24 Jun 2020 14:45:06 -0700. If I quoted-reply to that email, with this quoted_reply template (the default):

On {{dateFormat (.OriginalDate | toLocal) "Mon Jan 2, 2006 at 3:04 PM MST"}}, {{(index .OriginalFrom 0).Name}} wrote:
{{wrapText .OriginalText 72 | quote }}

then the timestamp that ends up being prepended to the message is, somehow, Wed Jun 24, 2020 at 3:45 PM BST. That's totally wrong; it should be 10:45 PM BST.

#384 Default quoted_reply template is broken for anyone not in PST timezone 3 months ago

Ticket created by ~sersorrel on ~sircmpwn/aerc2

Since 2fcd77f (https://lists.sr.ht/~sircmpwn/aerc/patches/9851), aerc by default converts message timestamps for quote headers to the "local" timezone, then labels that time as PST. Last time I checked, this is not the correct behaviour for the vast majority of the world. I think most "normal people" would be more confused by timestamps in the incorrect timezone than UTC timestamps with no labelled timezone at all.