~sircmpwn/aerc2#29: 
Add color configuration

Status
REPORTED
Submitter
~sircmpwn
Assigned to
No-one
Submitted
1 year, 3 months ago
Updated
10 days ago
Labels
feature

~psylok 10 months ago

+1 at least for unread mails, bold is not visible enough

~srivathsan 5 months ago

I would like to take a stab at adding colors to aerc. Has there been any decisions made regarding the possible implementation or configuration?

My current idea for configuration, contains a [colors] sections in the aerc.conf file. This would contain the default tcell style and subsection that would work for specific objects.

[colors]
bg=ColorGreen
fg=ColorWhite
attr=Bold

[colors:index_read]
fg=ColorMaroon

[colors:index_unread]
fg=ColorBlue

These configurations get converted to tcell.style and can be accessed through a public function in config.

config.GetStyle(STYLE_DEFAULT)
config.GetStyle(STYLE_INDEX_READ)

I am looking forward to any comments on this idea. PS. Sorry about my horrible color choices :p

~labrat 5 months ago

On Wed, Jan 29, 2020 at 09:31:41AM -0000, ~srivathsan wrote:

I would like to take a stab at adding colors to aerc. Has there been any decisions made regarding the possible implementation or configuration?

Sounds great!

Please do take this discussion to the normal aerc mailing list. I'm not sure how many of the usual contributors actually browse through the todos. Drew (semi-) jokingly said that he /dev/nulls the todo emails for one...

Is this acceptable for you?

~srivathsan 5 months ago

Sure no worries, I will post the same there and ask for comments.

~rek2 a month ago

+1 as well, at least for unread mails, bold is not visible enough. the regular mutt theme is very good and if compatible will be nice

~labrat a month ago

~rek2 don't add +1 comments to any of the issues please. They do not add any value to the open tickets, popularity isn't important. If you want something to be done faster, send a patch. If you would have checked the mailing list you would have seen that there is a patch available in a rather late revision.

~labrat REPORTED FIXED a month ago

~rek2 10 days ago

Hello, I I enabled this and was working very well, and customized my colors, did a update and is gone, I check and the changes got reverted... why? it was working amazingly... can we reopen this again since is reverted?

~srivathsan 10 days ago

On Sat Jun 27, 2020 at 9:59 PM CEST, ~rek2 wrote:

Hello, I I enabled this and was working very well, and customized my colors, did a update and is gone, I check and the changes got reverted... why? it was working amazingly... can we reopen this again since is reverted?

View on the web: https://todo.sr.ht/~sircmpwn/aerc2/29#comment-11951

Hey, Drew had some issues with the patch as it broke some stuff. He also mentioned that proper instruction were needed to install and revert back if needed which I do agree with.

Unfortunately, life has gotten in the way for now. I will be sending a new patch after rebasing and fixing the documentation issues so that it can tested properly before being merging again.

Keep a watch on the mailing list, I should have some time in the comming week to do some work on this patchset.

~srivathsan referenced this from #29 10 days ago

~rek2 10 days ago

hey @srivathsan thanks for much for the fast response, good to hear you are actually going to work on this, when is up and into the master, make sure you post some way to give you beer money or something, :) thanks for your work.

~labrat FIXED REPORTED 10 days ago

Register here or Log in to comment, or comment via email.