~sircmpwn/aerc2#416: 
aerc's :term doesn't seem to support high/true color, some text decorations

Based on this test shell script, aerc's :term seem to produce quite limited results, lacking the support of high and true color, italicized and dimmed text.

Here's a screenshot of aerc's :term on the left, usual shell on the right (both running in iTerm for macOS): https://i.imgur.com/rkrnITQ.png

Status
REPORTED
Submitter
~john1doe
Assigned to
No-one
Submitted
3 months ago
Updated
a month ago
Labels
No labels applied.

~john1doe 2 months ago

So, it DOES support true color after all, it just checks $TERM for having truecolor in the name.

Still, italics support is missing (despite tcell sort of has it now). And also Vim's cursor shapes aren't working.

~y0ast 2 months ago

Hmm, so it seems aerc depends on a custom tcell fork: https://git.sr.ht/~sircmpwn/aerc/tree/master/go.mod#L48

And it seems Drew reverted a specific commit to support $COLORTERM (which I believe is what is most often used to verify truecolor support):

https://git.sr.ht/~sircmpwn/tcell/commit/1f7dcc6382865d9b65b422e3c5f13d0ed1c12329

fish gets really unhappy if I start using TERM=xterm-truecolor aerc, so it would be very helpful if aerc would depend on the original tcell, instead of the custom fork.

~john1doe 2 months ago

As far as I understand, you can compile aerc with the original tcell:

  • remove replace github.com/gdamore/tcell => git.sr.ht/~sircmpwn/tcell v0.0.0-20190807054800-3fdb6bc01a50 from go.mod file
  • run go get github.com/gdamore/tcell@master

It doesn't seem to solve any of the problems, though: both italic and truecolor (without abusing TERM) still will not function.

~y0ast a month ago

I just submitted a patch that fixes truecolor detection by updating tcell: https://lists.sr.ht/~sircmpwn/aerc/patches/11972

Curious to hear if it works for you and perhaps fixes your other problems too!

Register here or Log in to comment, or comment via email.