~sircmpwn/builds.sr.ht#158:
Non-YAML file in .builds leads to "Missing image in manifest"

When pushing to a repo with a .builds/ directory, if a non-YAML file is present (e.g. a README file), a Missing image in manifest exception is shown and the builds are not triggered.

remote: Traceback (most recent call last):
remote:   File "hooks/post-update", line 58, in <module>
remote:     do_post_update(repo, git_repo, ref)
remote:   File "/usr/lib/python3.6/site-packages/gitsrht/worker.py", line 107, in do_post_update
remote:     submit_builds(repo, git_repo, commit)
remote:   File "/usr/lib/python3.6/site-packages/gitsrht/worker.py", line 57, in submit_builds
remote:     m = Manifest(yaml.safe_load(m))
remote:   File "/usr/lib/python3.6/site-packages/buildsrht/manifest.py", line 62, in __init__
remote:     raise Exception("Missing image in manifest")
remote: Exception: Missing image in manifest

So it appears that all files in the .builds directory are treated as YAML regardless of their extension.

Status
REPORTED
Submitter
~jpgrayson
Assigned to
No-one
Submitted
11 months ago
Updated
11 months ago
Labels
No labels applied.